Skip to content

Commit ea0ffb9

Browse files
committed
more attempts at improvements
1 parent 9b21a2c commit ea0ffb9

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

test/orthnull.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ using .TestSuite
1313

1414
is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
1515

16-
m = 54
17-
for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
16+
m = 23
17+
for T in (BLASFloats..., GenericFloats...), n in (17, m, 27)
1818
TestSuite.seed_rng!(123)
1919
if T BLASFloats
2020
if CUDA.functional()

test/svd.jl

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,7 @@ if !is_buildkite
2020
# LAPACK algorithms:
2121
for T in BLASFloats, m in (0, 54), n in (0, 37, m, 63)
2222
TestSuite.seed_rng!(123)
23-
LAPACK_SVD_ALGS = (
24-
LAPACK_QRIteration(),
25-
LAPACK_DivideAndConquer(),
26-
LAPACK_SafeDivideAndConquer(; fixgauge = true),
27-
)
23+
LAPACK_SVD_ALGS = (QRIteration(), DivideAndConquer(), SafeDivideAndConquer(; fixgauge = true))
2824
TestSuite.test_svd(T, (m, n))
2925
TestSuite.test_svd_algs(T, (m, n), LAPACK_SVD_ALGS)
3026
end
@@ -52,11 +48,7 @@ if CUDA.functional()
5248
for T in BLASFloats, m in (0, 23), n in (0, 17, m, 27)
5349
TestSuite.seed_rng!(123)
5450
TestSuite.test_svd(CuMatrix{T}, (m, n))
55-
CUDA_SVD_ALGS = (
56-
CUSOLVER_QRIteration(),
57-
CUSOLVER_SVDPolar(),
58-
CUSOLVER_Jacobi(),
59-
)
51+
CUDA_SVD_ALGS = (QRIteration(), SVDViaPolar(), Jacobi())
6052
TestSuite.test_svd_algs(CuMatrix{T}, (m, n), CUDA_SVD_ALGS)
6153
end
6254

@@ -85,7 +77,7 @@ if AMDGPU.functional()
8577
for T in BLASFloats, m in (0, 23), n in (0, 17, m, 27)
8678
TestSuite.seed_rng!(123)
8779
TestSuite.test_svd(ROCMatrix{T}, (m, n))
88-
AMD_SVD_ALGS = (ROCSOLVER_QRIteration(), ROCSOLVER_Jacobi())
80+
AMD_SVD_ALGS = (QRIteration(), Jacobi())
8981
TestSuite.test_svd_algs(ROCMatrix{T}, (m, n), AMD_SVD_ALGS)
9082
end
9183

0 commit comments

Comments
 (0)