Add api for rai error (#362)

* Avoid using arr in ModelRun API, align redisai.h ModelRun signature

* added llapi to handle RAI_Error struct

* review fixes

Co-authored-by: Luca Antiga <luca.antiga@orobix.com>

Author: Meir Shpilraien (Spielrein)

src/err.c

@@ -23,6 +23,18 @@ char *RAI_Chomp(const char *src) {
   return str;
 }
 
+const char* RAI_GetError(RAI_Error *err) {
+  return err->detail;
+}
+
+const char* RAI_GetErrorOneLine(RAI_Error *err) {
+  return err->detail_oneline;
+}
+
+RAI_ErrorCode RAI_GetErrorCode(RAI_Error *err) {
+  return err->code;
+}
+
 void RAI_SetError(RAI_Error *err, RAI_ErrorCode code, const char *detail) {
   if(!err){
     return;

src/err.h

@@ -52,6 +52,33 @@ int RAI_InitError(RAI_Error **err);
  */
 void RAI_SetError(RAI_Error *err, RAI_ErrorCode code, const char *detail);
 
+/**
+ * Return the error description
+ *
+ * @param err
+ * @return error description
+ * @param err
+ */
+const char* RAI_GetError(RAI_Error *err);
+
+/**
+ * Return the error description as one line
+ *
+ * @param err
+ * @return error description as one line
+ * @param err
+ */
+const char* RAI_GetErrorOneLine(RAI_Error *err);
+
+/**
+ * Return the error code
+ *
+ * @param err
+ * @return error code
+ * @param err
+ */
+RAI_ErrorCode RAI_GetErrorCode(RAI_Error *err);
+
 /**
  * Resets an previously used/allocated RAI_Error
  *
@@ -66,4 +93,4 @@ void RAI_ClearError(RAI_Error *err);
  */
 void RAI_FreeError(RAI_Error *err);
 
-#endif
+#endif

src/redisai.c

@@ -1188,6 +1188,13 @@ static int RedisAI_RegisterApi(RedisModuleCtx* ctx) {
 
   REGISTER_API(GetLLAPIVersion, ctx);
 
+  REGISTER_API(InitError, ctx);
+  REGISTER_API(ClearError, ctx);
+  REGISTER_API(FreeError, ctx);
+  REGISTER_API(GetError, ctx);
+  REGISTER_API(GetErrorOneLine, ctx);
+  REGISTER_API(GetErrorCode, ctx);
+
   REGISTER_API(TensorCreate, ctx);
   REGISTER_API(TensorCreateByConcatenatingTensors, ctx);
   REGISTER_API(TensorCreateBySlicingTensor, ctx);

src/redisai.h

@@ -30,12 +30,38 @@ typedef struct RAI_Error RAI_Error;
 #define REDISAI_DEVICE_CPU 0
 #define REDISAI_DEVICE_GPU 1
 
+#define RedisAI_ErrorCode int
+#define RedisAI_ErrorCode_OK 0
+#define RedisAI_ErrorCode_EMODELIMPORT 1
+#define RedisAI_ErrorCode_EMODELCONFIGURE 2
+#define RedisAI_ErrorCode_EMODELCREATE 3
+#define RedisAI_ErrorCode_EMODELRUN 4
+#define RedisAI_ErrorCode_EMODELSERIALIZE 5
+#define RedisAI_ErrorCode_EMODELFREE 6
+#define RedisAI_ErrorCode_ESCRIPTIMPORT 7
+#define RedisAI_ErrorCode_ESCRIPTCONFIGURE 8
+#define RedisAI_ErrorCode_ESCRIPTCREATE 9
+#define RedisAI_ErrorCode_ESCRIPTRUN 10
+#define RedisAI_ErrorCode_EUNSUPPORTEDBACKEND 11
+#define RedisAI_ErrorCode_EBACKENDNOTLOADED 12
+#define RedisAI_ErrorCode_ESCRIPTFREE 13
+#define RedisAI_ErrorCode_ETENSORSET 14
+#define RedisAI_ErrorCode_ETENSORGET 15
+#define RedisAI_ErrorCode_EDAGRUN 17
+
 enum RedisAI_DataFmt {
   REDISAI_DATA_BLOB = 0,
   REDISAI_DATA_VALUES,
   REDISAI_DATA_NONE
 };
 
+int MODULE_API_FUNC(RedisAI_InitError)(RAI_Error **err);
+void MODULE_API_FUNC(RedisAI_ClearError)(RAI_Error *err);
+void MODULE_API_FUNC(RedisAI_FreeError)(RAI_Error *err);
+const char* MODULE_API_FUNC(RedisAI_GetError)(RAI_Error *err);
+const char* MODULE_API_FUNC(RedisAI_GetErrorOneLine)(RAI_Error *err);
+RedisAI_ErrorCode MODULE_API_FUNC(RedisAI_GetErrorCode)(RAI_Error *err);
+
 RAI_Tensor* MODULE_API_FUNC(RedisAI_TensorCreate)(const char* dataTypeStr, long long* dims, int ndims);
 RAI_Tensor* MODULE_API_FUNC(RedisAI_TensorCreateByConcatenatingTensors)(RAI_Tensor** ts, long long n);
 RAI_Tensor* MODULE_API_FUNC(RedisAI_TensorCreateBySlicingTensor)(RAI_Tensor* t, long long offset, long long len);
@@ -96,6 +122,13 @@ static int RedisAI_Initialize(RedisModuleCtx* ctx){
     return REDISMODULE_ERR;
   }
 
+  REDISAI_MODULE_INIT_FUNCTION(ctx, InitError);
+  REDISAI_MODULE_INIT_FUNCTION(ctx, ClearError);
+  REDISAI_MODULE_INIT_FUNCTION(ctx, FreeError);
+  REDISAI_MODULE_INIT_FUNCTION(ctx, GetError);
+  REDISAI_MODULE_INIT_FUNCTION(ctx, GetErrorOneLine);
+  REDISAI_MODULE_INIT_FUNCTION(ctx, GetErrorCode);
+
   REDISAI_MODULE_INIT_FUNCTION(ctx, GetLLAPIVersion);
 
   REDISAI_MODULE_INIT_FUNCTION(ctx, TensorCreate);