Skip to content

[NEW] Ability for Rocket.Chat Apps to delete messages (Derived from #24806) #25515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
murtaza98 wants to merge 2 commits into from
Closed

[NEW] Ability for Rocket.Chat Apps to delete messages (Derived from #24806) #25515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddfacb3
[NEW] Ability for Rocket.Chat Apps to delete messages (Derived from #…
May 15, 2022
202a067
Merge branch 'develop' into apps/delete-msg
debdutdeb Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion apps/meteor/app/apps/server/bridges/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { Messages, Users, Subscriptions } from '../../../models/server';
import { updateMessage } from '../../../lib/server/functions/updateMessage';
import { executeSendMessage } from '../../../lib/server/methods/sendMessage';
import notifications from '../../../notifications/server/lib/Notifications';
import type { AppServerOrchestrator } from '../orchestrator';
import { AppServerOrchestrator } from '../orchestrator';
import { deleteMessage } from '../../../lib/server';

export class AppMessageBridge extends MessageBridge {
// eslint-disable-next-line no-empty-function
Expand Down Expand Up @@ -51,6 +52,21 @@ export class AppMessageBridge extends MessageBridge {
updateMessage(msg, editor);
}

protected async delete(messageId: string, appId: string): Promise<void> {
this.orch.debugLog(`The App ${appId} is deleting a message with id: "${messageId}".`);

const appUser = Users.findOneByAppId(appId, {});
if (!appUser) {
throw new Error('Invalid app user, cannot delete message.');
}
const message = Messages.findOneById(messageId);
if (!message) {
throw new Error('Invalid message, cannot delete message.');
}

await deleteMessage(message, appUser);
}

protected async notifyUser(user: IUser, message: IMessage, appId: string): Promise<void> {
this.orch.debugLog(`The App ${appId} is notifying a user.`);

Expand Down
1 change: 1 addition & 0 deletions apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@
"Apps_Permissions_server-setting_write": "Modify settings in this server",
"Apps_Permissions_room_read": "Access room information",
"Apps_Permissions_room_write": "Create and modify rooms",
"Apps_Permissions_message_delete": "Delete messages",
"Apps_Permissions_message_read": "Access messages",
"Apps_Permissions_message_write": "Send and modify messages",
"Apps_Permissions_livechat-status_read": "Access Livechat status information",
Expand Down