fix: prevent ServiceWorker registration errors in VS Code webview #9904
+241
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9903. Feedback and guidance are welcome.
Problem
VS Code webviews have security restrictions that prevent ServiceWorker registration. When third-party libraries (like PostHog analytics) attempt to register ServiceWorkers, it causes an "InvalidStateError" that prevents the webview from loading properly.
Solution
This PR implements a three-pronged approach to prevent ServiceWorker registration errors:
navigator.serviceWorkerwith a mock implementation that safely rejects registration attemptsChanges
serviceWorkerPrevention.tsutility to detect VS Code webview environment and prevent ServiceWorker registrationindex.tsxto initialize prevention before any libraries loadTelemetryClient.tsto disable PostHog features that might use ServiceWorkersTesting
Notes
The fix is designed to be non-invasive and only affects the VS Code webview environment. Regular browser environments are not affected.
Fixes #9903