fix: Address PR #5 review comments - hook ordering, error handling, polyfills#20
Merged
miccy merged 2 commits intosync/bun-migrationfrom Feb 3, 2026
Merged
Conversation
9 tasks
…olyfills Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update migration to Bun and Biome with documentation
fix: Address PR #5 review comments - hook ordering, error handling, polyfills
Feb 3, 2026
miccy
approved these changes
Feb 3, 2026
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from PR #5 review thread #5 (review)
Changes
Vue composable hook ordering:
useOwnernow callsuseEvolu()unconditionally at function top, preventing conditional hook invocation that violates Vue's composable rulesRelay error handling:
startRelayreturn type changed fromTask<Relay, never, ...>toTask<Relay, SqliteError, ...>. Errors now propagate correctly instead of returning a disposedAsyncDisposableStackTest polyfill: Added
Promise.withResolverspolyfill topackages/nodejs/test/setup.tsfor environments lacking ES2024 supportCleanup: Removed accidentally committed
biome_errors_2.txtdiagnostic fileNotes
Workflow file documentation changes (
.github/workflows/*.yaml) not included due to repository protection rules requiring exemption approval.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.