Skip to content

fix: Address PR #5 review comments - hook ordering, error handling, polyfills#20

Merged
miccy merged 2 commits intosync/bun-migrationfrom
copilot/sub-pr-5-yet-again
Feb 3, 2026
Merged

fix: Address PR #5 review comments - hook ordering, error handling, polyfills#20
miccy merged 2 commits intosync/bun-migrationfrom
copilot/sub-pr-5-yet-again

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 3, 2026

Addresses code review feedback from PR #5 review thread #5 (review)

Changes

  • Vue composable hook ordering: useOwner now calls useEvolu() unconditionally at function top, preventing conditional hook invocation that violates Vue's composable rules

  • Relay error handling: startRelay return type changed from Task<Relay, never, ...> to Task<Relay, SqliteError, ...>. Errors now propagate correctly instead of returning a disposed AsyncDisposableStack

  • Test polyfill: Added Promise.withResolvers polyfill to packages/nodejs/test/setup.ts for environments lacking ES2024 support

  • Cleanup: Removed accidentally committed biome_errors_2.txt diagnostic file

Notes

Workflow file documentation changes (.github/workflows/*.yaml) not included due to repository protection rules requiring exemption approval.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…olyfills

Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Copilot AI changed the title [WIP] Update migration to Bun and Biome with documentation fix: Address PR #5 review comments - hook ordering, error handling, polyfills Feb 3, 2026
Copilot AI requested a review from miccy February 3, 2026 18:29
@miccy miccy marked this pull request as ready for review February 3, 2026 18:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 3, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy miccy merged commit b10ef63 into sync/bun-migration Feb 3, 2026
1 check passed
@miccy miccy deleted the copilot/sub-pr-5-yet-again branch February 3, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants