Show window controls when idle

[Keith94]

Expected behavior of the wanted feature

Enable window_top_bar functionality when mpv is on idle screen (no file loaded).

Workaround for enabling native title bar only on idle screen: #251 (comment)

[Samillion]

Oh wow, I didn't even realize this doesn't show, even on stock osc! I wonder why.

[Keith94]

Oh wow, I didn't even realize this doesn't show, even on stock osc! I wonder why.

Yeah it's strange indeed; there's a feature request for it here: mpv-player/mpv#13167

[Anthonyy232]

This would actually be awesome.

[zenwav]

I second this.

[Samillion]

I'm still trying to figure out why mpv hasn't implemented this by default in osc.lua. I mentioned it a couple of times on irc, but I wasn't always present the last month.

[Keith94]

True. Would be simple to port it over once they add it officially.

[Samillion]

Indeed. One of the main things I wanted to keep with ModernZ is that it's based on osc.lua.

This specific feature would require a drastic change (osc render). Unless there is a simple way that my brain is unable to think of yet.

[Keith94]

There's another popular 3rd party OSC that implemented it, but I didn't look into how he did it.

[Samillion]

There's another popular 3rd party OSC that implemented it, but I didn't look into how he did it.

What's their repo link? I'd love to see their implementation.

[Keith94]

https://github.com/tomasklaen/uosc

[Samillion]

Ohh. Yeah. To be very frank, uosc is an amazing implementation as an osc overall that broke the osc standard and went over and beyond. It is the closest thing to a GUI toolkit yet it's just an OSC.

To be clear, this feature is doable. A simple (broken) example, in the tick function:

ModernZ/modernz.lua

Lines 3112 to 3117 in 80ea6b7

	tick = function()
	if state.marginsREQ == true then
	state.marginsREQ = false
	end
	if not state.enabled then return end

It controls osc render:

ModernZ/modernz.lua

Lines 3162 to 3170 in 80ea6b7

	elseif (state.fullscreen and user_opts.showfullscreen)
	or (not state.fullscreen and user_opts.showwindowed) then
	-- render the OSC
	render()
	else
	-- Flush OSD
	render_wipe()
	end

Changing this only shows it (broken) with osc in idle:

        end
+    end
-    elseif (state.fullscreen and user_opts.showfullscreen)
+    if (state.fullscreen and user_opts.showfullscreen)

Obviously it's broken here because it's essentially ticking render constantly, but it shows you why the osc would need many changes.

• Adjust show/hide_osc behavior for idle state and include osc render/render_wipe
• Adjust default values (such as title, play controls and such) to match an idle state
• Adjust show/hide_osc to be separate for top bar and controls (bottom)

The end result though would be many changes that would break the "based on osc.lua" thing. I think this is me hesitating because of paranoia and false set of standards.

Also, I'm almost certain there is even a simpler way to do this that my brain is just not picking up lol.

[Keith94]

Damn. That could explain why it hasn't made it into mpv yet because of all the changes. Probably not a lot of discussion around it either.

Should we close and re open it later once it's added?

[Samillion]

I don't mind leaving it open, since the same mpv issue has been open for over a year now. Maybe this will allow it to be discovered more and someone shares an input or an idea that make the implementation of this feature not so complicated..