Merge pull request #690 from SceneView/claude/check-progress-Digzb

Thomas Gorisse · web-flow · commit db5df3048fe0 · 2026-03-21T22:46:32.000+01:00
fix: add missing position parameter to SphereNode composable
diff --git a/sceneview/src/main/java/io/github/sceneview/SceneScope.kt b/sceneview/src/main/java/io/github/sceneview/SceneScope.kt
@@ -366,6 +366,7 @@ open class SceneScope @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP_PREFIX) constru
         stacks: Int = Sphere.DEFAULT_STACKS,
         slices: Int = Sphere.DEFAULT_SLICES,
         materialInstance: MaterialInstance? = null,
+        position: Position = Position(x = 0f),
         apply: SphereNodeImpl.() -> Unit = {},
         content: (@Composable NodeScope.() -> Unit)? = null
     ) {
@@ -381,6 +382,7 @@ open class SceneScope @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP_PREFIX) constru
         }
         SideEffect {
             node.updateGeometry(radius = radius, center = center, stacks = stacks, slices = slices)
+            node.position = position
         }
         NodeLifecycle(node, content)
     }

Original file line number	Diff line number	Diff line change
`@@ -366,6 +366,7 @@ open class SceneScope @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP_PREFIX) constru`
`366`	`366`	`stacks: Int = Sphere.DEFAULT_STACKS,`
`367`	`367`	`slices: Int = Sphere.DEFAULT_SLICES,`
`368`	`368`	`materialInstance: MaterialInstance? = null,`
	`369`	`+ position: Position = Position(x = 0f),`
`369`	`370`	`apply: SphereNodeImpl.() -> Unit = {},`
`370`	`371`	`content: (@Composable NodeScope.() -> Unit)? = null`
`371`	`372`	`) {`
`@@ -381,6 +382,7 @@ open class SceneScope @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP_PREFIX) constru`
`381`	`382`	`}`
`382`	`383`	`SideEffect {`
`383`	`384`	`node.updateGeometry(radius = radius, center = center, stacks = stacks, slices = slices)`
	`385`	`+ node.position = position`
`384`	`386`	`}`
`385`	`387`	`NodeLifecycle(node, content)`
`386`	`388`	`}`