`package.json` schema incorrect

[tj-commits]

Area with issue?

JSON Schema

✔️ Expected Behavior

I created a package.json file with the package name as @is-(unknown)/is-one or similar (a package name with parentheses in the scope, which is valid) in Visual Studio Code. I expected this to be valid as it is.

❌ Actual Behavior

I saw the warning String does not match the pattern of "^(?:(?:@(?:[a-z0-9-*~][a-z0-9-*._~]*)?/[a-z0-9-._~])|[a-z0-9-~])[a-z0-9-._~]*$"

I created this issue on the VSCode repository first but they referenced that I needed to open issue here.

microsoft/vscode#283826 (comment)

IDE or code editor.

Visual Studio Code

Are you making a PR for this?

No, someone else must create the PR.

[eureka0928]

Hi @hyperupcall happy new year!
May I take up this issue?
cc: @madskristensen

[eureka0928]

Hi @domdomegg would you check this issue if I can take?
Thank you

[domdomegg]

@leonace924 I'm not a maintainer of that schema unfortunately. But don't see why you couldn't try to pick this up and raise a PR anyway :)

[hyperupcall]

@leonace924 Go ahead! I would recommend removing the regex match entirely.

[eureka0928]

@hyperupcall can you review this if this looks good to you? or completely removing pattern regex is fine?

[RedCMD]

^(?:@(?:[a-z0-9-*~()][a-z0-9-*._~()]*)?/[a-z0-9-._~()]|[a-z0-9-~()])[a-z0-9-._~()]*$

[hyperupcall]

@eureka928 Maybe hard to say without seeing a diff, but @RedCMD has a lot of experience with regular expressions.

[RedCMD]

• https://github.com/npm/validate-npm-package-name?tab=readme-ov-file#naming-rules
  states to not use ~)('!* and to not start with _
• https://github.com/npm/normalize-package-data/blob/aa01d035e74a3d7d83d1cd5466ba4988e910c9e3/lib/fixer.js#L361-L369
• https://github.com/npm/package-json/blob/bd3b7eafa70c17ae96778386572ff98a5c01baff/lib/normalize.js#L158-L164
• https://github.com/npm/validate-npm-package-name/blob/622224dabeb3c381be046d7131e10d9d466fd500/lib/index.js#L10-L96
• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent

valid package name:

• https://github.com/npm/package-json/blob/bd3b7eafa70c17ae96778386572ff98a5c01baff/lib/normalize.js#L107-L110
• https://github.com/npm/normalize-package-data/blob/aa01d035e74a3d7d83d1cd5466ba4988e910c9e3/lib/fixer.js#L356-L359
• cannot start with .
• cannot contain uppercase letters A-Z
• cannot contain any of /@+%: or whitespace
• must use URL safe characters encodeURIComponent() e.g.. only a–z 0–9 - _ . ! ~ * ' ( )

valid scoped package name:

• https://github.com/npm/package-json/blob/bd3b7eafa70c17ae96778386572ff98a5c01baff/lib/normalize.js#L112-L134
• https://github.com/npm/normalize-package-data/blob/aa01d035e74a3d7d83d1cd5466ba4988e910c9e3/lib/fixer.js#L341-L354
• must start with @
• must contain exactly one /
• cannot contain uppercase letters A-Z
• must use URL safe characters encodeURIComponent() e.g.. only a–z 0–9 - _ . ! ~ * ' ( )

or if following validate-npm-package-name

^(?:(?:@(?:[a-z0-9-*~][a-z0-9-*._~]*)?/[a-z0-9-._~])|[a-z0-9-~])[a-z0-9-._~]*$
^(?:@[a-z0-9-_.!~*'()]+/[a-z0-9-_.!~*'()]+|[a-z0-9-_!~*'()][a-z0-9-_.!~*'()]*)$
^(?:@[a-z0-9-_.!~*'()]+/[a-z0-9-_]|[a-z0-9])[a-z0-9-_.]*$