[FIX] This fixes #47 (checks for the test name in moulitest)

Author: Seluj78

42PyChecker.py

@@ -41,7 +41,8 @@ def main():
     # @todo Check what option is given based on the selected project.
     parser.add_argument("--no-required", help="Disables required functions check", action="store_true")
     parser.add_argument("--no-libft-unit-test", help="Disables libft-unit-test", action="store_true")
-    parser.add_argument("--no-benchmark", help="Disables libft-unit-test benchmarking", action="store_false")
+    # @todo: Fix --do-benchmark option for libft-unit-test
+    parser.add_argument("--do-benchmark", help="Disables libft-unit-test benchmarking", action="store_false")
 
     args = parser.parse_args()
     if args.show_w:

PyChecker/testing_suite/libft_unit_test.py

@@ -5,31 +5,7 @@
 
 import platform
 import subprocess
-
-from chardet.universaldetector import UniversalDetector
-
-detector = UniversalDetector()
-
-
-def get_encoding_type(current_file):
-    detector.reset()
-    for line in open(current_file):
-        detector.feed(line)
-        if detector.done: break
-    detector.close()
-    return detector.result['encoding']
-
-
-def convert(file: str, target:str):
-    import codecs
-    BLOCKSIZE = 1048576  # or some other, desired size in bytes
-    with codecs.open(file, "r", get_encoding_type(file)) as sourceFile:
-        with codecs.open(target, "w+", "utf-8") as targetFile:
-            while True:
-                contents = sourceFile.read(BLOCKSIZE)
-                if not contents:
-                    break
-                targetFile.write(contents)
+import os
 
 
 def run(root_path: str, args):
@@ -47,12 +23,10 @@ def run(root_path: str, args):
         print(result)
         result = subprocess.run(['make', 'f', '-C', root_path + '/testing_suites/libft-unit-test', 'LIBFTDIR=' + args.path], stdout=subprocess.PIPE, stderr=subprocess.STDOUT).stdout.decode('utf-8')
         print(result)
-        convert(root_path + '/testing_suites/libft-unit-test/result.log', root_path + '/result.log')
-        with open(root_path + '/result.log', 'r') as file2:
-            data = file2.read()
-            file.write(data)
+        file.write(result)
+        os.rename(root_path + '/testing_suites/libft-unit-test/result.log', root_path + '/.mylibftunittest-results')
         if args.do_benchmark:
-            result = subprocess.run([root_path + '/testing_suite/libft-unit-test/run_test', '-b'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT).stdout.decode('utf-8')
+            result = subprocess.run([root_path + '/testing_suites/libft-unit-test/run_test', '-b'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT).stdout.decode('utf-8')
             print(result)
             file.write(result)
-    # @todo return results from benchmark and tests
+    # @todo return results from benchmark and tests

PyChecker/testing_suite/moulitest.py

@@ -32,7 +32,9 @@ def exclude_libft_bonuses(root_path: str):
 
 
 def execute_test(test_name: str, root_path: str):
-    # @todo add a protection if test_name isn't compatible with the current project and if not in list of available test for moulitest
+    available_tests = ['libft_part1', 'libft_part2', 'libft_bonus', 'get_next_line', 'gnl', 'ft_ls', 'ft_printf']
+    if test_name not in available_tests:
+        raise ValueError("Given test not in moulitest available tests.")
     with open(root_path + "/.mymoulitest", 'w+') as file:
         file.write("*------------------------------------------------------*\n")
         file.write("MOULITEST\n")