Change "indefinitecy right" to use visa's table instead of visa's from movements

[mischa-s]

Tasks:

• Update the visa and identity model and factories relationships
• Currently

  PresenceChecker/app/services/eligibility_service.rb

  Line 94 in 6588ffc

  def eligibility_values

  uses @client.movements.order(:carrier_date_time).each. Instead it should use something like @client.visas.
• Visas need to be added to app/views/clients/show.html.erb.
• Tests maybe need to be updated
• Visa types specified on seeds should to be updated to be separate visa entries

[mischa-s]

@robholmesnz if one of the devs have time this week are you happy for this to be implemented?