Better yet don't make it a extension method on string

mythz · mythz · commit 10214402c104 · 2017-12-08T23:33:12.000-05:00
diff --git a/src/ServiceStack.Text/HttpUtils.cs b/src/ServiceStack.Text/HttpUtils.cs
@@ -106,7 +106,7 @@ public static string SetHashParam(this string url, string key, string val)
             return url + prefix + key + "=" + val.UrlEncode();
         }
 
-        public static bool HasRequestBody(this string httpMethod)
+        public static bool HasRequestBody(string httpMethod)
         {
             switch (httpMethod)
             {
@@ -534,7 +534,7 @@ public static string SendStringToUrl(this string url, string method = null,
                     writer.Write(requestBody);
                 }
             }
-            else if (method != null && method.HasRequestBody())
+            else if (method != null && HasRequestBody(method))
             {
                 webReq.ContentLength = 0;
             }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public static string SetHashParam(this string url, string key, string val)`
`106`	`106`	`return url + prefix + key + "=" + val.UrlEncode();`
`107`	`107`	`}`
`108`	`108`
`109`		`- public static bool HasRequestBody(this string httpMethod)`
	`109`	`+ public static bool HasRequestBody(string httpMethod)`
`110`	`110`	`{`
`111`	`111`	`switch (httpMethod)`
`112`	`112`	`{`
`@@ -534,7 +534,7 @@ public static string SendStringToUrl(this string url, string method = null,`
`534`	`534`	`writer.Write(requestBody);`
`535`	`535`	`}`
`536`	`536`	`}`
`537`		`- else if (method != null && method.HasRequestBody())`
	`537`	`+ else if (method != null && HasRequestBody(method))`
`538`	`538`	`{`
`539`	`539`	`webReq.ContentLength = 0;`
`540`	`540`	`}`