Only increment counts when we acknowledge #372
Closed
+57
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| acknowledged, _ = redis.pipelined do |pipeline| | ||
| @queue.acknowledge(id, error: payload, pipeline: pipeline) | ||
| record_stats(stats, pipeline: pipeline) | ||
| acknowledged = @queue.acknowledge(id, error: payload) |
There was a problem hiding this comment.
@ChrisBr Do we still need to move the counting to after recording?
if test.requeued?
self.requeues += 1
elsif test.skipped?
self.skips += 1
elsif test.error?
self.errors += 1
elsif test.failure
self.failures += 1
end
Contributor
Author
There was a problem hiding this comment.
No because we only count on acknowledge. Counting / success requeue always is fine, errors are problematic.
ChrisBr
commented
Feb 6, 2026
| record_stats(stats, pipeline: pipeline) | ||
| acknowledged = @queue.acknowledge(id, error: payload) | ||
| if acknowledged == 1 | ||
| record_stats(stats) |
Contributor
Author
There was a problem hiding this comment.
Only record stats on failure if this worker actually acknowledged
ChrisBr
force-pushed
the
cbruckmayer/only-increment-on-ack
branch
from
a6ae8cb to
3f3dd19
Compare
ChrisBr
force-pushed
the
cbruckmayer/only-increment-on-ack
branch
from
3f3dd19 to
928f0b2
Compare
ChrisBr
commented
Feb 6, 2026
| record_stats(stats) | ||
| @queue.increment_test_failed | ||
| else | ||
| record_stats({"ignored" => 1}) |
Contributor
Author
There was a problem hiding this comment.
I don't love just updating ignored but it should be fine.
ChrisBr
commented
Feb 6, 2026
| if acknowledged | ||
| record_stats(stats) | ||
| else | ||
| record_stats({"ignored" => 1}) |
Contributor
Author
There was a problem hiding this comment.
I don't love just updating ignored but it should be fine.
Contributor
Author
There was a problem hiding this comment.
Thinking more, this is wrong because it would only ever set 1.
thadcraft-shopify
approved these changes
Feb 6, 2026
Contributor
Author
|
Superseded by #373 We already log the lost tests to warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test times out and gets executed by another worker and then worker 1 succeeds and worker 2 fails we will acknowledge the success (and ignore the failure). However, we do still count failure in the global counter which can cause some confusion in the log output.
Just to clarify, the overall build result is correct, just the log output is confusing.