Skip to content

Conversation

@FKauwe
Copy link
Contributor

@FKauwe FKauwe commented Feb 6, 2026

WHY are these changes introduced?

Fixes #1016

Building off the architecture for a new theme doctor command in this PR, I introduce a warning and confirm with the user before executing the theme doctor test suite, as the tests will interact with user's remote shop.

WHAT is this pull request doing?

  • add the renderConfirmationPrompt function to the doctor/theme/index.ts file
  • add a new unittest file and 2 unittests to verify that behavior for User Confirms and User Cancels are correct

looks like this when User Confirms(test suite executes):
Screenshot 2026-02-06 at 11 53 14 AM

and when User Cancels (exit the command):
Screenshot 2026-02-06 at 11 53 28 AM

How to test your changes?

pull my branch down locally
p build
run shopify-dev doctor theme -e <local-env-name> in external terminal
see the warning and prompt and the expected behaviors between Yes/No

@FKauwe FKauwe self-assigned this Feb 6, 2026
@FKauwe FKauwe requested a review from EvilGenius13 February 6, 2026 21:01
@FKauwe FKauwe marked this pull request as ready for review February 6, 2026 21:01
@FKauwe FKauwe requested review from a team as code owners February 6, 2026 21:01
@EvilGenius13
Copy link
Contributor

Great start @FKauwe!
Two things

  • Let's rebase with my branch as there were some changes and we should make sure everything still runs well.
  • Can we amend the message a little bit? Maybe add that some commands will change code within themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants