Move sbt override to cloud build#637
Conversation
|
/unit_test_scala |
|
/lint_test |
GiGL Automation@ 01:38:12UTC : 🔄 @ 01:46:58UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 01:38:16UTC : 🔄 @ 01:43:23UTC : ❌ Workflow failed. |
|
|
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Thanks matt! Can we ad comments to these overrides saying why we do them?
svij-sc
left a comment
There was a problem hiding this comment.
I would personally do:
cp path/to/repositories ~/.sbt/repositories once in run_command_on_active_checkout, then remove the -Dsbt.repository.config=repositories from .sbtopts file.
Or, just bake the repositories file inside the docker image for cloud build.
Then we have one source of truth not two.
But, this is fine too given we will deprecate scala code soon anyways.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO