Skip to content

Move sbt override to cloud build#637

Merged
mkolodner-sc merged 3 commits into
mainfrom
mkolodner-sc/fix_sbt_cloud_build
May 14, 2026
Merged

Move sbt override to cloud build#637
mkolodner-sc merged 3 commits into
mainfrom
mkolodner-sc/fix_sbt_cloud_build

Conversation

@mkolodner-sc
Copy link
Copy Markdown
Collaborator

Scope of work done

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@mkolodner-sc mkolodner-sc changed the title [WIP] full sbt override to cloud [WIP] full sbt override to cloud build May 13, 2026
@mkolodner-sc mkolodner-sc changed the title [WIP] full sbt override to cloud build [WIP] move sbt override to cloud build May 13, 2026
@mkolodner-sc
Copy link
Copy Markdown
Collaborator Author

/unit_test_scala

@mkolodner-sc
Copy link
Copy Markdown
Collaborator Author

/lint_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

GiGL Automation

@ 01:38:12UTC : 🔄 Scala Unit Test started.

@ 01:46:58UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

GiGL Automation

@ 01:38:16UTC : 🔄 Lint Test started.

@ 01:43:23UTC : ❌ Workflow failed.
Please check the logs for more details.

@mkolodner-sc mkolodner-sc changed the title [WIP] move sbt override to cloud build Move sbt override to cloud build May 13, 2026
@mkolodner-sc
Copy link
Copy Markdown
Collaborator Author

lint_test doesn't set use_cloud_run to True (default False), meaning the changes in this PR can't be triggered on comment for this test, and will only be seen on merge. We see through the success of the scala unit test that the change is captured.

@mkolodner-sc mkolodner-sc marked this pull request as ready for review May 13, 2026 19:20
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks matt! Can we ad comments to these overrides saying why we do them?

Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally do:

cp path/to/repositories ~/.sbt/repositories once in run_command_on_active_checkout, then remove the -Dsbt.repository.config=repositories from .sbtopts file.
Or, just bake the repositories file inside the docker image for cloud build.

Then we have one source of truth not two.

But, this is fine too given we will deprecate scala code soon anyways.

@mkolodner-sc mkolodner-sc enabled auto-merge May 13, 2026 22:53
@mkolodner-sc mkolodner-sc added this pull request to the merge queue May 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 14, 2026
@mkolodner-sc mkolodner-sc added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 12ef991 May 14, 2026
7 checks passed
@mkolodner-sc mkolodner-sc deleted the mkolodner-sc/fix_sbt_cloud_build branch May 14, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants