Skip to content

Commit 10c9ecd

Browse files
author
Lewis Youl
committed
refactor: eager load avatar records
1 parent d3f62ac commit 10c9ecd

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

app/controllers/home_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def index
1111
snippets = if user_signed_in?
1212
@snippets = current_user
1313
.snippets_for_feed
14-
.includes(:language)
14+
.includes(:language, :likes, user: { avatar_attachment: :blob })
1515
else
1616
# temp fix for when user not signed in
1717
Snippet

app/controllers/snippets_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ def index
55
@page_title = 'Snippet'
66
@user = User.find_by(id: params[:user_id]) || current_user
77
@display_popover = true
8-
@snippets = @user.filed_snippets.includes(:user, :folders, :language)
8+
@snippets = @user.filed_snippets.includes(:folders, :language, { user: { avatar_attachment: :blob } })
99
@languages = Language.all.to_json
1010

1111
# TODO: Extract this logic to model/service

app/controllers/users_controller.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ def show
1919

2020
# need to change current implementation to hit specific user snippets endpoint so can optionally show private ones
2121
snippets = if @user == current_user
22-
@user.filed_snippets
22+
@user.filed_snippets.includes(:language)
2323
.order(created_at: :desc)
2424
else
25-
@user.filed_snippets.public_snippets
25+
@user.filed_snippets.public_snippets.includes(:language)
2626
.order(created_at: :desc)
2727
end
2828

@@ -33,7 +33,7 @@ def show
3333

3434
format.json do
3535
@user = User.find_by(id: params[:id])
36-
@snippets = @user.filed_snippets.includes(:user, :folders)
36+
@snippets = @user.filed_snippets.includes(:user, :folders, :language)
3737
@languages = Language.all.to_json
3838

3939
# TODO: Extract this logic to model/service

0 commit comments

Comments
 (0)