fix/z-index stacking for hovercard

LewisYoul · LewisYoul · commit 5b0840966a2d · 2020-12-19T13:08:08.000Z
diff --git a/app/assets/stylesheets/_sidebar.scss b/app/assets/stylesheets/_sidebar.scss
@@ -3,7 +3,7 @@
 .sidebar {
   &--wrapper {
     position: fixed;
-    // top: 52px;
+    z-index: 1;
     margin-right: 15px;
   }
 
diff --git a/app/assets/stylesheets/alert.scss b/app/assets/stylesheets/alert.scss
@@ -1,6 +1,6 @@
 .alert-mask {	
   position: fixed;	
-  z-index: 9998;	
+  z-index: 6;	
   top: 0;	
   left: 0;	
   width: 100%;	
diff --git a/app/assets/stylesheets/modal.scss b/app/assets/stylesheets/modal.scss
@@ -1,6 +1,6 @@
 .modal-mask {
   position: fixed;
-  z-index: 4;
+  z-index: 5;
   top: 0;
   left: 0;
   width: 100%;
diff --git a/app/assets/stylesheets/popover.scss b/app/assets/stylesheets/popover.scss
@@ -7,7 +7,7 @@
     box-shadow: 0 0 6px rgba(0,0,0,.3);
     width: 120px;
     text-align: left;
-    z-index: 5;
+    z-index: 4;
     padding: 8px 0px;
     font-size: 14px;
     top: calc(100% + 8px);
diff --git a/app/javascript/controllers/hovercard_controller.js b/app/javascript/controllers/hovercard_controller.js
@@ -27,7 +27,7 @@ export default class extends Controller {
     }
 }
 		
-		hide(e) {
+		hide(event) {
       event.target.dataset.isHovering = false
 
       if (this.hasCardTarget) {

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export default class extends Controller {`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
`30`		`- hide(e) {`
	`30`	`+ hide(event) {`
`31`	`31`	`event.target.dataset.isHovering = false`
`32`	`32`
`33`	`33`	`if (this.hasCardTarget) {`