Add email type when retrieving custom variables (#174)

Author: gdbarron

ServiceNow/Private/Get-ServiceNowAuth.ps1

@@ -11,6 +11,8 @@ function Get-ServiceNowAuth {
 
     [OutputType([Hashtable])]
     [CmdletBinding()]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage('PSAvoidUsingConvertToSecureStringWithPlainText', '', Justification = 'requirement of azure automation')]
+
     Param (
         [Parameter()]
         [Alias('C')]
@@ -37,7 +39,7 @@ function Get-ServiceNowAuth {
             else {
                 $hashOut.Credential = $ServiceNowSession.Credential
             }
-    
+
             if ( $ServiceNowSession.Proxy ) {
                 $hashOut.Proxy = $ServiceNowSession.Proxy
                 if ( $ServiceNowSession.ProxyCredential ) {

ServiceNow/Private/Invoke-ServiceNowRestMethod.ps1

@@ -15,6 +15,8 @@ function Invoke-ServiceNowRestMethod {
 
     [OutputType([System.Management.Automation.PSCustomObject])]
     [CmdletBinding(SupportsPaging)]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage('PSUseBOMForUnicodeEncodedFile', '', Justification = 'issuees with *nix machines and no benefit')]
+
     Param (
         [parameter()]
         [ValidateSet('Get', 'Post', 'Patch', 'Delete')]

ServiceNow/Public/Get-ServiceNowRecord.ps1

@@ -298,7 +298,7 @@ function Get-ServiceNowRecord {
                 $customVarParams = @{
                     Table    = 'sc_item_option_mtom'
                     Property = 'sc_item_option.item_option_new.name', 'sc_item_option.item_option_new.sys_name', 'sc_item_option.item_option_new.type'
-                    Filter   = @('request_item', '-eq', $record.sys_id), 'and', @('sc_item_option.item_option_new.type', '-in', '1,2,3,4,5,6,7,8,9,10,16,18,21,22')
+                    Filter   = @('request_item', '-eq', $record.sys_id), 'and', @('sc_item_option.item_option_new.type', '-in', '1,2,3,4,5,6,7,8,9,10,16,18,21,22,26')
                     First    = 1000 # hopefully there isn't more custom vars than this, but we need to overwrite the default of 10
                 }
                 $customVars = Get-ServiceNowRecord @customVarParams

ServiceNow/Public/New-ServiceNowQuery.ps1

@@ -63,7 +63,7 @@
 #>
 function New-ServiceNowQuery {
 
-    [System.Diagnostics.CodeAnalysis.SuppressMessage('PSUseShouldProcessForStateChangingFunctions', 'No state is actually changing')]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage('PSUseShouldProcessForStateChangingFunctions', '', Justification = 'No state is actually changing')]
 
     [CmdletBinding()]
     [OutputType([System.String])]

ServiceNow/Public/New-ServiceNowSession.ps1

@@ -68,6 +68,8 @@ https://docs.servicenow.com/bundle/quebec-platform-administration/page/administe
 function New-ServiceNowSession {
 
     [CmdletBinding(DefaultParameterSetName = 'BasicAuth')]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage('PSAvoidUsingConvertToSecureStringWithPlainText', '', Justification = 'api call provides in plain text')]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage('PSUseShouldProcessForStateChangingFunctions', '', Justification = 'No state is actually changing')]
 
     param(
         [Parameter(Mandatory)]