Schema - MeasurementType - Set default value for 'derived' to false

[jomey]

We should have a default value for this table column, where we default to 'False' since that is the prominent value for all measurements. Derived types such as 'bulk SWE' are less often the case.

[aaarendt]

Happy to work on this. Isn't derived already set to default=False?

https://github.com/SnowEx/snowexsql/blob/a9cd7d4e47b9f97162160386731787ff7595f010/snowexsql/tables/measurement_type.py#L15C1-L15C45

[jomey]

Hm .. I do wonder how the DDL in DBeaver does not reflect this.
This is how the table looks after running the test suite to create the schema:

CREATE TABLE public.measurement_type (
	"name" text NOT NULL,
	units text NULL,
	"derived" bool NULL,
	id serial4 NOT NULL,
	CONSTRAINT measurement_type_pkey PRIMARY KEY (id)
);
CREATE INDEX ix_public_measurement_type_name ON public.measurement_type USING btree (name);

After running

ALTER TABLE measurement_type 
  ALTER COLUMN derived SET DEFAULT false;

The definition is as expected

CREATE TABLE public.measurement_type (
	"name" text NOT NULL,
	units text NULL,
	"derived" bool DEFAULT false NULL,
	id serial4 NOT NULL,
	CONSTRAINT measurement_type_pkey PRIMARY KEY (id)
);

[jomey]

Looks like I was looking for the server_default, which is different than the default