Skip to content

Waveform size inconsistency on 4 TEMPERA? #296

@plule

Description

@plule

Hello, while working on the ESPHome integration, I noticed that the 4 TEMPERA waveform arrays are shorter, where each row has 8 entries instead of 9:

#define WAVEFORM3BIT                                                                                                   \
    {{0, 0, 1, 1, 1, 1, 1, 0}, {1, 1, 1, 2, 1, 1, 0, 0}, {2, 1, 1, 0, 2, 1, 1, 0}, {0, 0, 0, 1, 1, 1, 2, 0},           \
     {2, 1, 1, 2, 1, 1, 2, 0}, {1, 2, 1, 1, 2, 1, 2, 0}, {1, 1, 1, 2, 1, 2, 2, 0}, {0, 0, 0, 0, 0, 2, 2, 0}};

Just like the other boards, it's however casted into a matrix of 9 rows and used with the same assumption. I think the missing values end up being zeroes:

#ifdef WAVEFORM3BIT
    uint8_t waveform3Bit[8][9] = WAVEFORM3BIT;
#endif

Is it something to be worried about, especially for the ESPHome integration where I added the leading zeroes?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions