refactor: release in spgemm

Author: IgorErin

src/GraphBLAS-sharp.Backend/Matrix/SpGeMM/Expand.fs

@@ -77,6 +77,8 @@ module Expand =
 
                 assignValues processor firstValues secondValues positions resultValues
 
+                positions.Free processor
+
                 Some(resultValues, resultColumns, resultRows)
 
     let expand (clContext: ClContext) workGroupSize =
@@ -238,8 +240,7 @@ module Expand =
 
             offsets.Free processor
 
-            // reducedValues, reducedColumns, reducedRows
-
+            // reducedValues, reducedColumns, reducedRows option
             reduceResult
 
     let runCOO opAdd opMul (clContext: ClContext) workGroupSize =
@@ -270,6 +271,8 @@ module Expand =
                 let leftMatrixValues, rightMatrixValues, columns, rows =
                     expand processor length segmentPointers leftMatrix rightMatrix
 
+                segmentPointers.Free processor
+
                 // multiply
                 let mulResult =
                     multiply processor leftMatrixValues rightMatrixValues columns rows
@@ -294,15 +297,11 @@ module Expand =
                         let reduceResult =
                             reduce processor allocationMode sortedValues sortedColumns sortedRows
 
-                        reduceResult
-                        |> Option.map
-                            (fun (reducedValues, reducedColumns, reducedRows) ->
-
-                                sortedValues.Free processor
-                                sortedColumns.Free processor
-                                sortedRows.Free processor
+                        sortedValues.Free processor
+                        sortedColumns.Free processor
+                        sortedRows.Free processor
 
-                                reducedValues, reducedColumns, reducedRows))
+                        reduceResult)
 
     let runOneStep opAdd opMul (clContext: ClContext) workGroupSize =
 
@@ -398,7 +397,6 @@ module Expand =
             let result = helper 0 0 [] |> List.rev
 
             segmentPointersByLeftMatrixRows.Free processor
-            rightMatrixRowsNNZ.Free processor
 
             result
 
@@ -429,6 +427,8 @@ module Expand =
                 getSegmentPointers processor leftMatrix.Columns rightMatrixRowsNNZ
 
             if length < maxAllocSize then
+                segmentLengths.Free processor
+
                 runOneStep processor allocationMode leftMatrix rightMatrixRowsNNZ rightMatrix
             else
                 let result =
@@ -441,6 +441,9 @@ module Expand =
                         rightMatrixRowsNNZ
                         rightMatrix
 
+                rightMatrixRowsNNZ.Free processor
+                segmentLengths.Free processor
+
                 match result with
                 | _ :: _ ->
                     let valuesList, columnsList, rowsList = result |> List.unzip3

tests/GraphBLAS-sharp.Tests/Backend/Matrix/SpGeMM/Expand.fs

@@ -181,8 +181,6 @@ let expandTests =
 
 let makeGeneralTest zero isEqual opAdd opMul testFun (leftArray: 'a [,], rightArray: 'a [,]) =
 
-    printfn "run test"
-
     let leftMatrix =
         Utils.createMatrixFromArray2D CSR leftArray (isEqual zero)
 
@@ -214,9 +212,7 @@ let makeGeneralTest zero isEqual opAdd opMul testFun (leftArray: 'a [,], rightAr
 let createGeneralTest (zero: 'a) isEqual (opAddQ, opAdd) (opMulQ, opMul) testFun =
     testFun opAddQ opMulQ context Utils.defaultWorkGroupSize
     |> makeGeneralTest zero isEqual opAdd opMul
-    |> testPropertyWithConfig
-        { config with endSize = 100; maxTest = 10 }
-        $"test on %A{typeof<'a>}"
+    |> testPropertyWithConfig config $"test on %A{typeof<'a>}"
 
 let generalTests =
     [ createGeneralTest 0 (=) ArithmeticOperations.intAdd ArithmeticOperations.intMul Matrix.SpGeMM.expand