Skip to content

PHPStan: Unreachable code in Manager classes and XmlSuccessRpcResponse #2

@Vitexus

Description

@Vitexus

PHPStan level 5 analysis reveals ~30 unreachable statements across Manager classes and XmlSuccessRpcResponse.

Found running PHPStan 2.x with PHP 8.4.

Affected files

Managers/MailingListsManager.php

  • Lines 80, 84, 89, 130, 134, 139 — unreachable statements after code that always terminates

Managers/MessagesManager.php

  • Lines 91, 95, 99, 103, 107, 111, 115 — unreachable statements

Managers/UsersManager.php

  • Lines 154, 158, 162, 166, 170, 175, 234, 238, 242, 246, 251, 304, 308, 313, 374, 379 — unreachable statements

RPC/Responses/XmlSuccessRpcResponse.php

  • Line 59 — unreachable statement

How to reproduce

vendor/bin/phpstan analyse --level=5 src/

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions