Fix button compatibility layer - don't override Chili Button globally

The previous implementation globally overrode Button and TabbedPanelButton,
breaking all Chili UI code. This caused crashes in links.lua trying to call
AutoDispose() on the fake Button object.

New approach:
- DON'T override Button or TabbedPanelButton globally
- Keep Chili buttons working normally
- During Editor:_FinalizeRmlUi(), convert Chili buttons to RmlUi buttons
- This happens only when an editor finalizes in RmlUi mode

Changes:
- rmlui_field_compat.lua:
  - Remove global Button and TabbedPanelButton overrides
  - Keep RmlUiButton and RmlUiTabbedPanelButton as conversion targets
  - Updated RmlUiTabbedPanelButton to accept caption/image directly

- editor.lua:
  - Add ConvertChiliButtonToRmlUi() helper function
  - Detect Chili TabbedPanelButton by SetPressedState + children
  - Detect Chili Button by caption + OnClick
  - Extract caption/image from Chili button children
  - Convert during _FinalizeRmlUi() instead of at creation time
  - Handle buttons in field.ctrl.children for AddControl() buttons

Now editors create Chili buttons as normal, and they get converted to
RmlUi buttons only when rendering in RmlUi mode. Chili UI remains intact.

Author: claude

scen_edit/view/editor.lua

@@ -724,23 +724,70 @@ end
 -- We load these fields last as they might be/contain subclasses of editor view
 SB.IncludeDir(Path.Join(SB.DIRS.SRC, 'view/fields'))
 
+-- Helper function to convert Chili button to RmlUi button
+local function ConvertChiliButtonToRmlUi(chiliButton)
+    if not chiliButton then
+        return nil
+    end
+
+    -- Check if it's a TabbedPanelButton (has SetPressedState and children with images/labels)
+    if chiliButton.SetPressedState and chiliButton.children then
+        -- Extract caption and image from children
+        local caption = ""
+        local image = nil
+        for _, child in pairs(chiliButton.children) do
+            if type(child) == "table" then
+                if child.classname == "label" and child.caption then
+                    caption = child.caption
+                elseif child.classname == "image" and child.file then
+                    image = child.file
+                end
+            end
+        end
+
+        -- Create RmlUi TabbedPanelButton
+        return RmlUiTabbedPanelButton({
+            x = chiliButton.x,
+            y = chiliButton.y,
+            tooltip = chiliButton.tooltip or "",
+            OnClick = chiliButton.OnClick or {},
+            caption = caption,
+            image = image,
+        })
+
+    -- Check if it's a regular Button (has caption and OnClick)
+    elseif chiliButton.caption and chiliButton.OnClick then
+        return RmlUiButton({
+            caption = chiliButton.caption,
+            OnClick = chiliButton.OnClick or {},
+            width = chiliButton.width,
+            height = chiliButton.height,
+            tooltip = chiliButton.tooltip,
+        })
+    end
+
+    return nil
+end
+
 -- RmlUi-specific finalization
 function Editor:_FinalizeRmlUi(children, opts)
     children = children or {}
     opts = opts or {}
 
-    -- Extract action buttons from children (TabbedPanelButton instances)
+    -- Convert Chili buttons to RmlUi buttons
     self.actionButtons = {}
     self.regularButtons = {}
 
     for _, child in ipairs(children) do
         if child and type(child) == "table" then
-            -- Check if it's an RmlUi button
-            if child.GenerateRml and child.OnClick then
-                if child.id and child.id:match("^action%-btn%-") then
-                    table.insert(self.actionButtons, child)
-                elseif child.id and child.id:match("^btn%-") then
-                    table.insert(self.regularButtons, child)
+            local rmlButton = ConvertChiliButtonToRmlUi(child)
+            if rmlButton then
+                -- TabbedPanelButtons become action buttons
+                if rmlButton.id and rmlButton.id:match("^action%-btn%-") then
+                    table.insert(self.actionButtons, rmlButton)
+                -- Regular buttons
+                elseif rmlButton.id and rmlButton.id:match("^btn%-") then
+                    table.insert(self.regularButtons, rmlButton)
                 end
             end
         end
@@ -765,11 +812,27 @@ function Editor:_FinalizeRmlUi(children, opts)
             if field.GenerateRml then
                 fieldsHtml = fieldsHtml .. field:GenerateRml()
             else
-                -- Check if it's a control with a button
-                if field.ctrl and field.ctrl.GenerateRml then
-                    fieldsHtml = fieldsHtml .. field.ctrl:GenerateRml()
+                -- Check if it's a control with a button inside
+                if field.ctrl then
+                    -- Try to convert the ctrl's children to buttons
+                    local ctrlHtml = ''
+                    if field.ctrl.children then
+                        for _, btnChild in pairs(field.ctrl.children) do
+                            local rmlBtn = ConvertChiliButtonToRmlUi(btnChild)
+                            if rmlBtn then
+                                ctrlHtml = ctrlHtml .. rmlBtn:GenerateRml()
+                                table.insert(self.regularButtons, rmlBtn)
+                            end
+                        end
+                    end
+                    if ctrlHtml ~= '' then
+                        fieldsHtml = fieldsHtml .. ctrlHtml
+                    else
+                        -- Fallback for other controls
+                        fieldsHtml = fieldsHtml .. '<div class="field-separator"></div>'
+                    end
                 else
-                    -- Fallback for other controls
+                    -- Fallback for fields without ctrl
                     fieldsHtml = fieldsHtml .. '<div class="field-separator"></div>'
                 end
             end

scen_edit/view/rmlui_field_compat.lua

@@ -41,13 +41,13 @@ AssetPickerWindow = RmlUiAssetPickerWindow
 ColorPickerWindow = RmlUiColorPickerWindow
 MaterialPickerWindow = RmlUiMaterialPickerWindow
 
--- Button Compatibility Layer
--- Create button objects that can generate RML
+-- Button classes for RmlUi mode
+-- These are created by Editor:_FinalizeRmlUi() when converting Chili buttons to RmlUi
 
 -- Counter for auto-generating button IDs
 local _BUTTON_INDEX = 0
 
--- RmlUi Button (used for regular Button:New{} calls via AddControl)
+-- RmlUi Button (converted from Chili Button:New{} during finalization)
 RmlUiButton = LCS.class{}
 
 function RmlUiButton:init(opts)
@@ -67,15 +67,7 @@ function RmlUiButton:GenerateRml()
     )
 end
 
--- Override Button table for RmlUi mode
-Button = {
-    New = function(opts)
-        return RmlUiButton(opts)
-    end
-}
-
--- TabbedPanelButton for action buttons (e.g., "Add", "Set", "Smooth")
--- These store their caption, image, tooltip and click handler
+-- RmlUi TabbedPanelButton (converted from Chili TabbedPanelButton during finalization)
 RmlUiTabbedPanelButton = LCS.class{}
 
 function RmlUiTabbedPanelButton:init(opts)
@@ -86,19 +78,9 @@ function RmlUiTabbedPanelButton:init(opts)
     self.tooltip = opts.tooltip or ""
     self.OnClick = opts.OnClick or {}
     self.pressed = false
-
-    -- Extract caption and image from children
-    self.caption = ""
-    self.image = nil
-    if opts.children then
-        for _, child in ipairs(opts.children) do
-            if child.caption then
-                self.caption = child.caption
-            elseif child.file then
-                self.image = child.file
-            end
-        end
-    end
+    self.caption = opts.caption or ""
+    self.image = opts.image
+    self.children = opts.children
 end
 
 function RmlUiTabbedPanelButton:SetPressedState(pressed)
@@ -129,19 +111,4 @@ function RmlUiTabbedPanelButton:GenerateRml()
     return html
 end
 
--- Helper functions to match Chili API
-function TabbedPanelButton(opts)
-    return RmlUiTabbedPanelButton(opts)
-end
-
-function TabbedPanelImage(opts)
-    -- Just return the opts, they'll be extracted by TabbedPanelButton
-    return opts
-end
-
-function TabbedPanelLabel(opts)
-    -- Just return the opts, they'll be extracted by TabbedPanelButton
-    return opts
-end
-
 Log.Notice("RmlUi field compatibility layer loaded - original API maintained")