From 2a8536f138b8283a9e34b36fe3466081a7cce493 Mon Sep 17 00:00:00 2001 From: Marc Gravell Date: Fri, 8 May 2026 07:58:05 +0100 Subject: [PATCH 1/2] reinstate failing test for investigation --- .gitignore | 1 + tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index c0024fb1f..5f13f9a17 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,7 @@ StackExchange.Redis.*.zip .idea/ .vs/ .vscode/ +.codex *.lock.json test-results*.xml packages/ diff --git a/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs b/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs index 9e448a836..dd48f7fa9 100644 --- a/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs +++ b/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs @@ -64,9 +64,6 @@ public async Task VectorSetAdd_WithAttributes() [InlineData(VectorSetQuantization.Binary, true)] public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization, bool useFp32) { -#if RELEASE // CI runs as Release - Assert.SkipWhen(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "CI oddness on Windows; needs attention - logged #3072"); -#endif await using var conn = Create(require: RedisFeatures.v8_0_0_M04); var db = conn.GetDatabase(); var key = Me() + "/" + quantization; From c0d1d562ef138991de1eaaffbaba3c3b740a38de Mon Sep 17 00:00:00 2001 From: Marc Gravell Date: Fri, 8 May 2026 09:07:25 +0100 Subject: [PATCH 2/2] fix CI --- tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs | 4 +++- tests/StackExchange.Redis.Tests/VectorSetUnitTests.cs | 5 ++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs b/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs index dd48f7fa9..3839d262f 100644 --- a/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs +++ b/tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs @@ -65,6 +65,8 @@ public async Task VectorSetAdd_WithAttributes() public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization, bool useFp32) { await using var conn = Create(require: RedisFeatures.v8_0_0_M04); + var server = conn.GetServer(RedisKey.Null); + Log($"Server version: {server.Version}"); var db = conn.GetDatabase(); var key = Me() + "/" + quantization; @@ -79,7 +81,7 @@ public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization attributes); request.UseFp32 = useFp32; request.Quantization = quantization; - request.ReducedDimensions = 64; + request.ReducedDimensions = 4; request.BuildExplorationFactor = 300; request.MaxConnections = 32; request.UseCheckAndSet = true; diff --git a/tests/StackExchange.Redis.Tests/VectorSetUnitTests.cs b/tests/StackExchange.Redis.Tests/VectorSetUnitTests.cs index 17bbb9475..fb86da65e 100644 --- a/tests/StackExchange.Redis.Tests/VectorSetUnitTests.cs +++ b/tests/StackExchange.Redis.Tests/VectorSetUnitTests.cs @@ -5,7 +5,6 @@ namespace StackExchange.Redis.Tests; -[Collection(NonParallelCollection.Name)] // because of the FP32 suppression public sealed class VectorSetUnitTests(ITestOutputHelper output) { // the aim of this test is to validate that we're sending the right thing - VADD is complex @@ -34,7 +33,7 @@ public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization attributes); request.UseFp32 = useFp32; request.Quantization = quantization; - request.ReducedDimensions = 64; + request.ReducedDimensions = 4; request.BuildExplorationFactor = 300; request.MaxConnections = 32; request.UseCheckAndSet = true; @@ -56,7 +55,7 @@ public async Task VectorSetAdd_WithEverything(VectorSetQuantization quantization Assert.Equal("VADD", req[0]); Assert.Equal("mykey", req[1]); Assert.Equal("REDUCE", req[2]); - Assert.Equal(64, req[3]); + Assert.Equal(4, req[3]); req = req.Slice(4); if (useFp32)