Skip to content

Unreachable Code in GameActionManager #25864

@WugWugg

Description

@WugWugg

Description:
Conditional is checking result which will always be Result.Succeed @ https://github.com/StrangeLoopGames/Eco/blame/16a1e23debc74e335d4b854e8ceb5c89846b1638/Server/Eco.Gameplay/GameActions/GameActionManager.cs#L52

This prevents the CustomActionTests on line 35 from returning a failure and stopping the action's execution.

Suggested Fix:
Line 52: if (r.Value is ResultType.Fail) return r;

Related:
#21772

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions