-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathdiff.patch
More file actions
1599 lines (1549 loc) · 59.6 KB
/
diff.patch
File metadata and controls
1599 lines (1549 loc) · 59.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
diff --git a/crates/cli/src/commands/mcp.rs b/crates/cli/src/commands/mcp.rs
index 0b2963cd..1ce4293d 100644
--- a/crates/cli/src/commands/mcp.rs
+++ b/crates/cli/src/commands/mcp.rs
@@ -73,7 +73,7 @@ pub(crate) async fn run(config: Arc<AppConfig>) -> Result<()> {
&config,
));
let session_service = Arc::new(SessionService::new(storage.clone(), llm.clone()));
- let knowledge_service = Arc::new(KnowledgeService::new(storage.clone()));
+ let knowledge_service = Arc::new(KnowledgeService::new(storage.clone(), embeddings.clone()));
let search_service = Arc::new(SearchService::new(
storage,
embeddings,
diff --git a/crates/cli/src/commands/search.rs b/crates/cli/src/commands/search.rs
index f5cf8a18..75738234 100644
--- a/crates/cli/src/commands/search.rs
+++ b/crates/cli/src/commands/search.rs
@@ -124,7 +124,7 @@ pub(crate) async fn run_backfill_embeddings(batch_size: usize) -> Result<()> {
pub(crate) async fn run_knowledge_lifecycle() -> Result<()> {
let storage = crate::create_storage_from_env().await?;
let decayed = storage.decay_confidence().await?;
- let archived = storage.auto_archive(30).await?;
+ let archived = storage.auto_archive(90).await?;
println!("Knowledge confidence lifecycle complete:");
println!(" Entries with decayed confidence: {decayed}");
println!(" Entries archived: {archived}");
diff --git a/crates/cli/src/commands/serve.rs b/crates/cli/src/commands/serve.rs
index e6c39f13..db227795 100644
--- a/crates/cli/src/commands/serve.rs
+++ b/crates/cli/src/commands/serve.rs
@@ -80,7 +80,7 @@ pub(crate) async fn run(port: u16, host: String, config: Arc<AppConfig>) -> Resu
&config,
));
let session_service = Arc::new(SessionService::new(storage.clone(), llm.clone()));
- let knowledge_service = Arc::new(KnowledgeService::new(storage.clone()));
+ let knowledge_service = Arc::new(KnowledgeService::new(storage.clone(), embeddings.clone()));
let search_service = Arc::new(SearchService::new(
storage.clone(),
embeddings.clone(),
diff --git a/crates/core/src/constants.rs b/crates/core/src/constants.rs
index fb8a6f7a..b0f90209 100644
--- a/crates/core/src/constants.rs
+++ b/crates/core/src/constants.rs
@@ -50,6 +50,12 @@ pub const KNOWLEDGE_TRIGRAM_LOG_THRESHOLD: f32 = 0.5;
/// Maximum number of trigram similarity candidates to consider.
pub const KNOWLEDGE_TRIGRAM_CANDIDATE_LIMIT: i64 = 3;
+/// Cosine similarity threshold for semantic dedup of knowledge entries.
+/// Knowledge entries with embedding similarity above this are merged.
+/// Higher than observation dedup (0.85) because knowledge titles are shorter
+/// and semantically denser — false positives are costlier.
+pub const KNOWLEDGE_SEMANTIC_DEDUP_THRESHOLD: f32 = 0.85;
+
/// Cap a user-supplied query limit to `MAX_QUERY_LIMIT`.
///
/// Both HTTP and MCP transports need to clamp user-supplied limits for DoS
diff --git a/crates/core/src/lib.rs b/crates/core/src/lib.rs
index 3eb60fe9..e884e2ad 100644
--- a/crates/core/src/lib.rs
+++ b/crates/core/src/lib.rs
@@ -31,6 +31,27 @@ pub use observation::*;
pub use project_filter::*;
pub use session::*;
+/// Strips UUID patterns from text (e.g., `"sshd needs absolute path b3b61de2-..."` → `"sshd needs absolute path"`).
+///
+/// Handles both full UUIDs (`8-4-4-4-12` hex) and truncated ones (e.g., `b3b61de2-...`).
+#[must_use]
+pub fn strip_uuid_from_title(title: &str) -> String {
+ use std::sync::LazyLock;
+
+ #[expect(
+ clippy::unwrap_used,
+ reason = "static regex pattern is compile-time validated"
+ )]
+ static UUID_RE: LazyLock<regex::Regex> = LazyLock::new(|| {
+ regex::Regex::new(
+ r"\s*[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4,}(?:-[0-9a-fA-F]*)*\.{0,3}\s*",
+ )
+ .unwrap()
+ });
+
+ UUID_RE.replace_all(title, " ").trim().to_string()
+}
+
/// Truncates a string to the given maximum length at a char boundary.
#[must_use]
pub fn truncate(s: &str, max_len: usize) -> &str {
@@ -44,3 +65,55 @@ pub fn truncate(s: &str, max_len: usize) -> &str {
s.get(..end).unwrap_or("")
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[test]
+ fn strip_uuid_full() {
+ assert_eq!(
+ strip_uuid_from_title("sshd needs absolute path b3b61de2-1234-5678-9abc-def012345678"),
+ "sshd needs absolute path"
+ );
+ }
+
+ #[test]
+ fn strip_uuid_truncated() {
+ assert_eq!(
+ strip_uuid_from_title("sshd needs absolute path b3b61de2-1234-5678..."),
+ "sshd needs absolute path"
+ );
+ }
+
+ #[test]
+ fn strip_uuid_mid_title() {
+ assert_eq!(
+ strip_uuid_from_title("Observation b3b61de2-1234-5678-9abc-def012345678 is important"),
+ "Observation is important"
+ );
+ }
+
+ #[test]
+ fn strip_uuid_no_uuid() {
+ assert_eq!(
+ strip_uuid_from_title("normal title without uuid"),
+ "normal title without uuid"
+ );
+ }
+
+ #[test]
+ fn strip_uuid_empty() {
+ assert_eq!(strip_uuid_from_title(""), "");
+ }
+
+ #[test]
+ fn strip_uuid_multiple() {
+ assert_eq!(
+ strip_uuid_from_title(
+ "a b3b61de2-1234-5678-9abc-def012345678 and c4c72ef3-5678-9abc-def0-123456789012"
+ ),
+ "a and"
+ );
+ }
+}
diff --git a/crates/http/src/handlers/context.rs b/crates/http/src/handlers/context.rs
index e36355c5..3eaf9e87 100644
--- a/crates/http/src/handlers/context.rs
+++ b/crates/http/src/handlers/context.rs
@@ -4,8 +4,10 @@ use axum::{
extract::{Query, State},
response::sse::{Event, Sse},
};
+use chrono::{Datelike, Utc};
use futures_util::stream::Stream;
use serde_json::json;
+use std::collections::HashSet;
use std::convert::Infallible;
use std::sync::Arc;
use tokio::sync::broadcast::error::RecvError;
@@ -87,8 +89,16 @@ async fn fetch_relevant_knowledge(
selected
}
+/// Selects knowledge entries using a multi-tier allocation strategy to prevent
+/// popularity bias (rich-get-richer death spiral where 93%+ entries never get retrieved).
+///
+/// Tier allocation for `limit=10`:
+/// - Tier 1 (40%): Project-relevant entries sorted by confidence
+/// - Tier 2 (20%): Recent entries (recency boost for new knowledge)
+/// - Tier 3 (20%): Proven entries with highest usage_count
+/// - Tier 4 (remaining): Exploration — never-seen entries rotated daily
fn select_relevant_knowledge(
- mut entries: Vec<GlobalKnowledge>,
+ entries: Vec<GlobalKnowledge>,
project: &str,
limit: usize,
) -> Vec<GlobalKnowledge> {
@@ -97,37 +107,88 @@ fn select_relevant_knowledge(
}
let normalized_project = project.trim().to_ascii_lowercase();
- entries.sort_by(|a, b| {
+ let mut selected: Vec<GlobalKnowledge> = Vec::with_capacity(limit);
+ let mut used_ids: HashSet<String> = HashSet::new();
+
+ // Tier 1: Project-relevant entries (up to 40% of slots)
+ let project_slots = (limit * 2 / 5).max(1);
+ let mut project_entries: Vec<_> = entries
+ .iter()
+ .filter(|k| {
+ k.source_projects
+ .iter()
+ .any(|p| p.trim().to_ascii_lowercase() == normalized_project)
+ })
+ .cloned()
+ .collect();
+ project_entries.sort_by(|a, b| b.confidence.total_cmp(&a.confidence));
+ for entry in project_entries.into_iter().take(project_slots) {
+ used_ids.insert(entry.id.clone());
+ selected.push(entry);
+ }
+
+ // Tier 2: Recent entries (up to 20% of slots) — recency boost for new knowledge
+ let recency_slots = (limit / 5).max(1);
+ let mut recent_entries: Vec<_> = entries
+ .iter()
+ .filter(|k| !used_ids.contains(&k.id))
+ .cloned()
+ .collect();
+ recent_entries.sort_by(|a, b| b.created_at.cmp(&a.created_at));
+ for entry in recent_entries.into_iter().take(recency_slots) {
+ used_ids.insert(entry.id.clone());
+ selected.push(entry);
+ }
+
+ // Tier 3: High-value proven entries (up to 20% of slots) — usage_count matters here
+ let proven_slots = (limit / 5).max(1);
+ let mut proven_entries: Vec<_> = entries
+ .iter()
+ .filter(|k| !used_ids.contains(&k.id) && k.usage_count > 0)
+ .cloned()
+ .collect();
+ proven_entries.sort_by(|a, b| {
b.usage_count
.cmp(&a.usage_count)
.then_with(|| b.confidence.total_cmp(&a.confidence))
- .then_with(|| a.title.cmp(&b.title))
});
-
- let mut selected = Vec::with_capacity(limit);
-
- for entry in &entries {
- if entry.source_projects.iter().any(|source| {
- let normalized_source = source.trim().to_ascii_lowercase();
- normalized_source == normalized_project
- }) {
- selected.push(entry.clone());
- if selected.len() == limit {
- return selected;
- }
- }
+ for entry in proven_entries.into_iter().take(proven_slots) {
+ used_ids.insert(entry.id.clone());
+ selected.push(entry);
}
- for entry in entries {
- if selected.iter().any(|picked| picked.id == entry.id) {
- continue;
+ // Tier 4: Exploration — never-seen entries (remaining slots)
+ // Breaks the death spiral: entries with usage_count=0 get a chance.
+ // Deterministic daily rotation ensures different entries surface each day.
+ let remaining = limit.saturating_sub(selected.len());
+ if remaining > 0 {
+ let mut unseen: Vec<_> = entries
+ .iter()
+ .filter(|k| !used_ids.contains(&k.id) && k.usage_count == 0)
+ .cloned()
+ .collect();
+ if !unseen.is_empty() {
+ let day_seed = u32::try_from(Utc::now().num_days_from_ce()).unwrap_or(0) as usize;
+ let rotate_by = day_seed % unseen.len();
+ unseen.rotate_left(rotate_by);
}
- selected.push(entry);
- if selected.len() == limit {
- break;
+ for entry in unseen.into_iter().take(remaining) {
+ selected.push(entry);
}
}
+ // If we still have room (fewer unseen than remaining), backfill from any unused
+ let still_remaining = limit.saturating_sub(selected.len());
+ if still_remaining > 0 {
+ let final_used: HashSet<_> = selected.iter().map(|k| k.id.as_str()).collect();
+ let backfill: Vec<_> = entries
+ .into_iter()
+ .filter(|k| !final_used.contains(k.id.as_str()))
+ .take(still_remaining)
+ .collect();
+ selected.extend(backfill);
+ }
+
selected
}
@@ -183,6 +244,24 @@ mod tests {
title: &str,
source_projects: Vec<&str>,
usage_count: i64,
+ ) -> GlobalKnowledge {
+ sample_knowledge_full(
+ id,
+ title,
+ source_projects,
+ usage_count,
+ 0.5,
+ "2026-01-01T00:00:00Z",
+ )
+ }
+
+ fn sample_knowledge_full(
+ id: &str,
+ title: &str,
+ source_projects: Vec<&str>,
+ usage_count: i64,
+ confidence: f64,
+ created_at: &str,
) -> GlobalKnowledge {
GlobalKnowledge::new(
id.to_owned(),
@@ -193,17 +272,17 @@ mod tests {
vec![],
source_projects.into_iter().map(str::to_owned).collect(),
vec![],
- 0.5,
+ confidence,
usage_count,
None,
- "2026-01-01T00:00:00Z".to_owned(),
- "2026-01-01T00:00:00Z".to_owned(),
+ created_at.to_owned(),
+ created_at.to_owned(),
None,
)
}
#[test]
- fn select_relevant_knowledge_prioritizes_project_matches_then_usage() {
+ fn select_relevant_knowledge_prioritizes_project_matches() {
let entries = vec![
sample_knowledge("global-100", "global high", vec![], 100),
sample_knowledge("global-90", "global medium", vec![], 90),
@@ -214,9 +293,123 @@ mod tests {
let selected = select_relevant_knowledge(entries, "demo", 3);
assert_eq!(selected.len(), 3);
- assert_eq!(selected[0].id, "project-10");
- assert_eq!(selected[1].id, "project-1");
- assert_eq!(selected[2].id, "global-100");
+ // Tier 1 should include both project entries (limit*2/5 = 1 for limit=3, but we have 2 project entries)
+ assert!(selected.iter().any(|k| k.id == "project-10"));
+ }
+
+ #[test]
+ fn empty_input_returns_empty() {
+ let selected = select_relevant_knowledge(vec![], "demo", 10);
+ assert!(selected.is_empty());
+ }
+
+ #[test]
+ fn zero_limit_returns_empty() {
+ let entries = vec![sample_knowledge("a", "a", vec![], 0)];
+ let selected = select_relevant_knowledge(entries, "demo", 0);
+ assert!(selected.is_empty());
+ }
+
+ #[test]
+ fn tier4_exploration_surfaces_unseen_entries() {
+ // All entries have usage_count=0, none are project-specific
+ let entries: Vec<_> = (0..20)
+ .map(|i| sample_knowledge(&format!("k-{i}"), &format!("knowledge {i}"), vec![], 0))
+ .collect();
+
+ let selected = select_relevant_knowledge(entries, "demo", 10);
+
+ assert_eq!(selected.len(), 10);
+ // With daily rotation, different entries get surfaced
+ }
+
+ #[test]
+ fn no_duplicate_ids_in_selection() {
+ let entries = vec![
+ sample_knowledge_full(
+ "a",
+ "proj entry",
+ vec!["demo"],
+ 5,
+ 0.9,
+ "2026-03-15T00:00:00Z",
+ ),
+ sample_knowledge_full("b", "recent", vec![], 0, 0.5, "2026-03-14T00:00:00Z"),
+ sample_knowledge_full("c", "proven", vec![], 10, 0.7, "2026-01-01T00:00:00Z"),
+ sample_knowledge_full("d", "unseen", vec![], 0, 0.3, "2026-01-01T00:00:00Z"),
+ ];
+
+ let selected = select_relevant_knowledge(entries, "demo", 4);
+
+ let ids: Vec<_> = selected.iter().map(|k| k.id.as_str()).collect();
+ let unique: std::collections::HashSet<_> = ids.iter().collect();
+ assert_eq!(
+ ids.len(),
+ unique.len(),
+ "duplicate IDs in selection: {ids:?}"
+ );
+ }
+
+ #[test]
+ fn multi_tier_allocation_with_limit_10() {
+ let mut entries = Vec::new();
+ // 3 project entries
+ for i in 0..3 {
+ entries.push(sample_knowledge_full(
+ &format!("proj-{i}"),
+ &format!("proj {i}"),
+ vec!["demo"],
+ 0,
+ 0.9 - (i as f64 * 0.1),
+ "2026-01-01T00:00:00Z",
+ ));
+ }
+ // 3 proven entries (high usage)
+ for i in 0..3 {
+ entries.push(sample_knowledge_full(
+ &format!("proven-{i}"),
+ &format!("proven {i}"),
+ vec![],
+ 50 - (i as i64 * 10),
+ 0.8,
+ "2026-01-01T00:00:00Z",
+ ));
+ }
+ // 10 unseen entries
+ for i in 0..10 {
+ entries.push(sample_knowledge_full(
+ &format!("unseen-{i}"),
+ &format!("unseen {i}"),
+ vec![],
+ 0,
+ 0.5,
+ "2026-01-01T00:00:00Z",
+ ));
+ }
+
+ let selected = select_relevant_knowledge(entries, "demo", 10);
+
+ assert_eq!(selected.len(), 10);
+
+ let project_count = selected
+ .iter()
+ .filter(|k| k.id.starts_with("proj-"))
+ .count();
+ let proven_count = selected
+ .iter()
+ .filter(|k| k.id.starts_with("proven-"))
+ .count();
+ let unseen_count = selected
+ .iter()
+ .filter(|k| k.id.starts_with("unseen-"))
+ .count();
+
+ // Tier 1: 4 project slots, but only 3 available
+ assert!(project_count >= 1, "should include project entries");
+ // Tier 3: proven entries should appear
+ assert!(proven_count >= 1, "should include proven entries");
+ // Tier 4: unseen entries should fill remaining slots
+ assert!(unseen_count >= 1, "should include exploration entries");
}
}
diff --git a/crates/http/src/handlers/cron.rs b/crates/http/src/handlers/cron.rs
index eec66dcb..dc94942d 100644
--- a/crates/http/src/handlers/cron.rs
+++ b/crates/http/src/handlers/cron.rs
@@ -22,29 +22,29 @@ pub async fn start_cron_scheduler(state: Arc<AppState>) {
loop_count = loop_count.wrapping_add(1);
- if loop_count % 60 == 0 {
- if let Some(ref infinite_mem) = state.infinite_mem {
- tracing::debug!("Cron: running infinite memory compression...");
- let mem = Arc::clone(infinite_mem);
- state.background_tasks.lock().await.spawn(async move {
- match mem.run_full_compression().await {
- Ok((five_min, hour, day)) => {
- if five_min > 0 || hour > 0 || day > 0 {
- tracing::info!(
- "Cron: created {} 5min, {} hour, {} day summaries",
- five_min,
- hour,
- day,
- );
- }
+ if loop_count.is_multiple_of(60)
+ && let Some(ref infinite_mem) = state.infinite_mem
+ {
+ tracing::debug!("Cron: running infinite memory compression...");
+ let mem = Arc::clone(infinite_mem);
+ state.background_tasks.lock().await.spawn(async move {
+ match mem.run_full_compression().await {
+ Ok((five_min, hour, day)) => {
+ if five_min > 0 || hour > 0 || day > 0 {
+ tracing::info!(
+ "Cron: created {} 5min, {} hour, {} day summaries",
+ five_min,
+ hour,
+ day,
+ );
}
- Err(e) => tracing::warn!("Cron: infinite memory error: {e:?}"),
}
- });
- }
+ Err(e) => tracing::warn!("Cron: infinite memory error: {e:?}"),
+ }
+ });
}
- if loop_count % 180 == 0 {
+ if loop_count.is_multiple_of(180) {
tracing::debug!("Cron: running embedding backfill...");
let state_clone = Arc::clone(&state);
state.background_tasks.lock().await.spawn(async move {
@@ -58,7 +58,7 @@ pub async fn start_cron_scheduler(state: Arc<AppState>) {
});
}
- if loop_count % 360 == 0 {
+ if loop_count.is_multiple_of(360) {
let state_clone = Arc::clone(&state);
state.background_tasks.lock().await.spawn(async move {
match state_clone.observation_service.run_dedup_sweep().await {
@@ -71,7 +71,7 @@ pub async fn start_cron_scheduler(state: Arc<AppState>) {
});
}
- if loop_count % 720 == 0 {
+ if loop_count.is_multiple_of(720) {
let state_clone = Arc::clone(&state);
state.background_tasks.lock().await.spawn(async move {
if let Err(e) = state_clone
@@ -84,7 +84,7 @@ pub async fn start_cron_scheduler(state: Arc<AppState>) {
});
}
- if loop_count % 17280 == 0 {
+ if loop_count.is_multiple_of(17280) {
let ttl_secs = state.config.dlq_ttl_secs();
let state_clone = Arc::clone(&state);
state.background_tasks.lock().await.spawn(async move {
@@ -102,7 +102,7 @@ pub async fn start_cron_scheduler(state: Arc<AppState>) {
});
}
- if loop_count % 2160 == 0 {
+ if loop_count.is_multiple_of(2160) {
let state_clone = Arc::clone(&state);
state.background_tasks.lock().await.spawn(async move {
match state_clone
@@ -125,7 +125,7 @@ pub async fn start_cron_scheduler(state: Arc<AppState>) {
});
}
- if loop_count % 360 == 0 {
+ if loop_count.is_multiple_of(360) {
let state_clone = Arc::clone(&state);
state.background_tasks.lock().await.spawn(async move {
match state_clone
diff --git a/crates/http/src/handlers/mod.rs b/crates/http/src/handlers/mod.rs
index 483d05be..46486eb5 100644
--- a/crates/http/src/handlers/mod.rs
+++ b/crates/http/src/handlers/mod.rs
@@ -17,12 +17,11 @@ pub(crate) fn check_admin_access(
headers: &axum::http::HeaderMap,
config: &opencode_mem_core::AppConfig,
) -> bool {
- if let Some(ref token) = config.admin_token {
- if let Some(provided) = headers.get("x-admin-token").and_then(|h| h.to_str().ok()) {
- if subtle::ConstantTimeEq::ct_eq(provided.as_bytes(), token.as_bytes()).into() {
- return true;
- }
- }
+ if let Some(ref token) = config.admin_token
+ && let Some(provided) = headers.get("x-admin-token").and_then(|h| h.to_str().ok())
+ && subtle::ConstantTimeEq::ct_eq(provided.as_bytes(), token.as_bytes()).into()
+ {
+ return true;
}
if config.admin_token.is_none() && addr.ip().is_loopback() {
diff --git a/crates/llm/src/ai_types.rs b/crates/llm/src/ai_types.rs
index f9de32f0..aba6c3ce 100644
--- a/crates/llm/src/ai_types.rs
+++ b/crates/llm/src/ai_types.rs
@@ -112,9 +112,12 @@ pub struct ObservationJson {
/// Context-aware compression action: "create", "update", or "skip"
#[serde(default = "default_action")]
pub action: String,
- /// UUID of existing observation to update (only for action="update")
+ /// UUID of existing observation to update (only for action="update") — legacy field
#[serde(default)]
pub target_id: Option<String>,
+ /// 1-based index of existing observation to update (only for action="update")
+ #[serde(default)]
+ pub target_number: Option<u32>,
/// Reason for skipping (only for action="skip")
#[serde(default)]
pub skip_reason: Option<String>,
diff --git a/crates/llm/src/compression_prompt.rs b/crates/llm/src/compression_prompt.rs
index 0da3b4e4..f9cc9e59 100644
--- a/crates/llm/src/compression_prompt.rs
+++ b/crates/llm/src/compression_prompt.rs
@@ -41,9 +41,8 @@ pub(crate) fn build_compression_prompt(
format!(" facts=[{}]", obs.facts.join(", "))
};
entries.push_str(&format!(
- "[{}] id=\"{}\" type={} title=\"{}\" | {}{}\n",
+ "[{}] type={} title=\"{}\" | {}{}\n",
i.saturating_add(1),
- obs.id,
obs.observation_type.as_str(),
obs.title,
narrative_preview,
@@ -57,7 +56,7 @@ EXISTING OBSERVATIONS (potentially related):
{entries}
DECISION (MANDATORY — choose exactly one):
- If this is genuinely NEW knowledge not covered by any existing observation → action: "create"
-- If this REFINES or ADDS TO an existing observation above → action: "update", target_id: "<id of the observation to update>"
+- If this REFINES or ADDS TO an existing observation above → action: "update", target_number: <number in brackets of the observation to update>
- If this adds ZERO new information beyond what already exists → action: "skip""#
)
};
@@ -86,7 +85,7 @@ DECISION (MANDATORY — choose exactly one):
format!(
r#"Return JSON:
- action: one of "create", "update", "skip"
-- target_id: id of existing observation to update (required if action is "update")
+- target_number: number in brackets of existing observation to update (required if action is "update")
- skip_reason: why this should be skipped (required if action is "skip")
- noise_level: one of [{noise_levels}]
- noise_reason: why this is/isn't worth remembering (max 100 chars)
diff --git a/crates/llm/src/knowledge.rs b/crates/llm/src/knowledge.rs
index 28f503d6..11048bc1 100644
--- a/crates/llm/src/knowledge.rs
+++ b/crates/llm/src/knowledge.rs
@@ -91,11 +91,15 @@ Return JSON: {{"extract": false, "reason": "..."}}"#,
LlmError::MissingField(format!("unknown knowledge_type: {}", knowledge_type_str))
})?;
- Ok(Some(KnowledgeInput::new(
- knowledge_type,
- extraction
+ let title = opencode_mem_core::strip_uuid_from_title(
+ &extraction
.title
.unwrap_or_else(|| observation.title.clone()),
+ );
+
+ Ok(Some(KnowledgeInput::new(
+ knowledge_type,
+ title,
extraction
.description
.unwrap_or_else(|| observation.narrative.clone().unwrap_or_default()),
diff --git a/crates/llm/src/observation.rs b/crates/llm/src/observation.rs
index db472e78..cf90e317 100644
--- a/crates/llm/src/observation.rs
+++ b/crates/llm/src/observation.rs
@@ -30,7 +30,7 @@ fn parse_observation_response(
id: &str,
session_id: &str,
project: Option<&str>,
- candidate_ids: &std::collections::HashSet<&str>,
+ candidates: &[opencode_mem_core::Observation],
) -> Result<CompressionResult, LlmError> {
let stripped = opencode_mem_core::strip_markdown_json(response);
let obs_json: ObservationJson =
@@ -109,22 +109,37 @@ fn parse_observation_response(
.created_at(Utc::now())
.build();
- // Determine action: update requires valid target_id in candidate set
+ // Determine action: update requires valid target resolved from candidates
if action == "update" {
- if let Some(ref target_id) = obs_json.target_id {
- if candidate_ids.contains(&target_id.as_str()) {
- return Ok(CompressionResult::Update {
- target_id: target_id.clone(),
- observation,
- });
- }
- tracing::warn!(
- target_id = %target_id,
- "LLM returned update with target_id not in candidate set — treating as create"
- );
- } else {
- tracing::warn!("LLM returned action=update without target_id — treating as create");
+ // Resolve target: prefer target_number (index into candidates), fall back to target_id (legacy)
+ let resolved_target_id = obs_json
+ .target_number
+ .and_then(|n| {
+ let idx = n.checked_sub(1)? as usize;
+ candidates.get(idx).map(|o| o.id.to_string())
+ })
+ .or_else(|| {
+ obs_json.target_id.as_ref().and_then(|tid| {
+ if candidates.iter().any(|o| o.id.as_ref() == tid.as_str()) {
+ Some(tid.clone())
+ } else {
+ None
+ }
+ })
+ });
+
+ if let Some(target_id) = resolved_target_id {
+ return Ok(CompressionResult::Update {
+ target_id,
+ observation,
+ });
}
+ tracing::warn!(
+ target_number = ?obs_json.target_number,
+ target_id = ?obs_json.target_id,
+ candidates_len = candidates.len(),
+ "LLM returned update with unresolvable target — treating as create"
+ );
}
if action != "create" {
@@ -167,16 +182,13 @@ impl LlmClient {
max_tokens: None,
};
- let candidate_ids: std::collections::HashSet<&str> =
- candidates.iter().map(|o| o.id.as_ref()).collect();
-
let response = self.chat_completion(&request).await?;
parse_observation_response(
&response,
id,
input.session_id.as_ref(),
project,
- &candidate_ids,
+ candidates,
)
}
diff --git a/crates/mcp/tests/degraded_mode.rs b/crates/mcp/tests/degraded_mode.rs
index df6b0984..2111875c 100644
--- a/crates/mcp/tests/degraded_mode.rs
+++ b/crates/mcp/tests/degraded_mode.rs
@@ -82,7 +82,7 @@ fn setup_degraded_services() -> (
&config,
));
let session_service = Arc::new(SessionService::new(backend.clone(), llm.clone()));
- let knowledge_service = Arc::new(KnowledgeService::new(backend.clone()));
+ let knowledge_service = Arc::new(KnowledgeService::new(backend.clone(), None));
let search_service = Arc::new(SearchService::new(
backend,
None,
diff --git a/crates/service/src/knowledge_service.rs b/crates/service/src/knowledge_service.rs
index 4c54a15d..9aab2398 100644
--- a/crates/service/src/knowledge_service.rs
+++ b/crates/service/src/knowledge_service.rs
@@ -3,20 +3,30 @@ use std::sync::Arc;
use opencode_mem_core::{
GlobalKnowledge, KnowledgeInput, KnowledgeSearchResult, KnowledgeType, cap_query_limit,
};
-use opencode_mem_storage::traits::KnowledgeStore;
+use opencode_mem_embeddings::LazyEmbeddingService;
+use opencode_mem_storage::traits::{EmbeddingStore, KnowledgeStore};
use opencode_mem_storage::{StorageBackend, StorageError};
use crate::ServiceError;
+const PROVENANCE_SIMILARITY_THRESHOLD: f32 = 0.75;
+
#[derive(Clone)]
pub struct KnowledgeService {
storage: Arc<StorageBackend>,
+ embeddings: Option<Arc<LazyEmbeddingService>>,
}
impl KnowledgeService {
#[must_use]
- pub fn new(storage: Arc<StorageBackend>) -> Self {
- Self { storage }
+ pub fn new(
+ storage: Arc<StorageBackend>,
+ embeddings: Option<Arc<LazyEmbeddingService>>,
+ ) -> Self {
+ Self {
+ storage,
+ embeddings,
+ }
}
pub fn circuit_breaker(&self) -> &opencode_mem_storage::CircuitBreaker {
@@ -52,11 +62,29 @@ impl KnowledgeService {
id: &str,
input: KnowledgeInput,
) -> Result<GlobalKnowledge, ServiceError> {
- let result = self
- .storage
- .guarded(|| self.storage.save_knowledge_with_id(id, input.clone()))
- .await;
- self.with_cb(result)
+ let needs_provenance = input.source_observation.is_none() && self.embeddings.is_some();
+
+ let embedding = self.generate_knowledge_embedding(&input).await;
+
+ let result = if let Some(emb) = embedding {
+ self.storage
+ .guarded(|| {
+ self.storage
+ .save_knowledge_with_embedding(id, input.clone(), emb.clone())
+ })
+ .await
+ } else {
+ self.storage
+ .guarded(|| self.storage.save_knowledge_with_id(id, input.clone()))
+ .await
+ };
+ let knowledge = self.with_cb(result)?;
+
+ if needs_provenance {
+ self.spawn_provenance_linking(knowledge.clone());
+ }
+
+ Ok(knowledge)
}
pub async fn delete_knowledge(&self, id: &str) -> Result<bool, ServiceError> {
@@ -102,9 +130,37 @@ impl KnowledgeService {
self.update_knowledge_usage_batch(&[id.to_owned()]).await
}
- /// Fire-and-forget usage_count increment. Failures are logged at warn level
- /// and never propagate to the caller — reading knowledge must never fail
- /// because of a usage tracking issue.
+ async fn generate_knowledge_embedding(&self, input: &KnowledgeInput) -> Option<Vec<f32>> {
+ let embeddings = self.embeddings.as_ref()?;
+ let text = format!("{} {}", input.title.trim(), input.description);
+ let embeddings_clone = Arc::clone(embeddings);
+ let embed_result = tokio::task::spawn_blocking(move || {
+ use opencode_mem_embeddings::EmbeddingProvider;
+ embeddings_clone.embed(&text)
+ })
+ .await;
+
+ match embed_result {
+ Ok(Ok(vec)) => Some(vec),
+ Ok(Err(e)) => {
+ tracing::warn!(
+ title = %input.title,
+ error = %e,
+ "Knowledge embedding generation failed, falling back to non-semantic dedup"
+ );
+ None
+ }
+ Err(e) => {
+ tracing::warn!(
+ title = %input.title,
+ error = %e,
+ "Knowledge embedding spawn_blocking panicked"
+ );
+ None
+ }
+ }
+ }
+
fn spawn_usage_increment(&self, ids: Vec<String>) {
let storage = Arc::clone(&self.storage);
tokio::spawn(async move {
@@ -118,6 +174,87 @@ impl KnowledgeService {
});
}
+ fn spawn_provenance_linking(&self, knowledge: GlobalKnowledge) {
+ let Some(ref embeddings) = self.embeddings else {
+ return;
+ };
+ if !knowledge.source_observations.is_empty() {
+ return;
+ }
+
+ let embeddings = Arc::clone(embeddings);
+ let storage = Arc::clone(&self.storage);
+ let knowledge_id = knowledge.id.clone();
+
+ tokio::spawn(async move {
+ let text = format!("{} {}", knowledge.title, knowledge.description);
+ let embeddings_clone = Arc::clone(&embeddings);
+ let embed_result = tokio::task::spawn_blocking(move || {
+ use opencode_mem_embeddings::EmbeddingProvider;
+ embeddings_clone.embed(&text)
+ })
+ .await;
+
+ let embedding = match embed_result {
+ Ok(Ok(vec)) => vec,
+ Ok(Err(e)) => {
+ tracing::warn!(
+ knowledge_id = %knowledge_id,
+ error = %e,
+ "Provenance linking: embedding generation failed"
+ );
+ return;
+ }
+ Err(e) => {
+ tracing::warn!(
+ knowledge_id = %knowledge_id,
+ error = %e,
+ "Provenance linking: spawn_blocking panicked"
+ );
+ return;
+ }
+ };
+
+ let similar = match storage
+ .find_similar(&embedding, PROVENANCE_SIMILARITY_THRESHOLD, None)
+ .await
+ {
+ Ok(Some(m)) => m,
+ Ok(None) => return,
+ Err(e) => {
+ tracing::warn!(
+ knowledge_id = %knowledge_id,
+ error = %e,
+ "Provenance linking: find_similar failed"
+ );
+ return;
+ }
+ };
+
+ match storage
+ .link_source_observation(&knowledge_id, &similar.observation_id)
+ .await
+ {
+ Ok(true) => {
+ tracing::info!(
+ knowledge_id = %knowledge_id,
+ observation_id = %similar.observation_id,
+ similarity = %similar.similarity,
+ "Auto-linked provenance via embedding similarity"
+ );
+ }
+ Ok(false) => {}
+ Err(e) => {
+ tracing::warn!(
+ knowledge_id = %knowledge_id,
+ error = %e,
+ "Provenance linking: link_source_observation failed"
+ );
+ }
+ }
+ });
+ }
+
pub async fn update_knowledge_usage_batch(&self, ids: &[String]) -> Result<(), ServiceError> {
let result = self
.storage
@@ -144,7 +281,7 @@ impl KnowledgeService {
pub async fn run_confidence_lifecycle(&self) -> Result<(u64, u64), ServiceError> {
let decayed = self.decay_confidence().await?;
- let archived = self.auto_archive(30).await?;
+ let archived = self.auto_archive(90).await?;
Ok((decayed, archived))
}
}
diff --git a/crates/service/src/observation_service/mod.rs b/crates/service/src/observation_service/mod.rs
index 239f8352..9bcc5f38 100644
--- a/crates/service/src/observation_service/mod.rs
+++ b/crates/service/src/observation_service/mod.rs
@@ -118,30 +118,30 @@ impl ObservationService {
let infinite_fut = self.store_infinite_memory(&tool_call, None);
let compress_fut = async {
let result = self.compress_and_save(id, &tool_call).await?;
- if let Some((ref obs, false)) = result {
- if obs.id.0 != id {
- let tombstone = Observation::builder(
- id.to_owned(),
- obs.session_id.clone(),
- obs.observation_type,
- format!("[merged into {}]", obs.id),
- )
- .noise_level(opencode_mem_core::NoiseLevel::Negligible)
- .noise_reason(format!("Tombstone: merged into {}", obs.id))
- .build();
-
- let result = self
- .storage
- .guarded(|| self.storage.save_observation(&tombstone))
- .await;
- if let Err(e) = self.with_cb(result) {
- tracing::warn!(
- tombstone_id = %id,
- merged_into = %obs.id,
- error = %e,
- "Failed to save tombstone observation — stale original may remain visible"
- );
- }
+ if let Some((ref obs, false)) = result
+ && obs.id.0 != id
+ {
+ let tombstone = Observation::builder(
+ id.to_owned(),
+ obs.session_id.clone(),