From 0edafbf38129001925aba7690bf41087fb273d83 Mon Sep 17 00:00:00 2001 From: Devin Collins Date: Thu, 13 Nov 2025 19:16:03 -0800 Subject: [PATCH] Handle requests errors properly --- MediaController.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/MediaController.py b/MediaController.py index 8fc77b6..b74bb7a 100644 --- a/MediaController.py +++ b/MediaController.py @@ -269,6 +269,9 @@ def thumbnail(self, player_name: str = None) -> list[str]: continue if path.startswith("https"): path = self.get_web_thumnail(path) + if not path: + thumbnails.append(None) + continue path = path.replace("file://", "") thumbnails.append(path) except (KeyError, IndexError) as e: @@ -334,8 +337,12 @@ def download_file(self, url: str, path: str = "", file_name: str = None) -> str: path (str): The path of the downloaded file. """ - response = requests.get(url, stream=True) - + try: + response = requests.get(url, stream=True) + except requests.exceptions.RequestException as e: + log.error(f"An error occurred during the request: {e}") + return None + if file_name is None: file_name = self.get_file_name_from_url(url) @@ -349,6 +356,6 @@ def download_file(self, url: str, path: str = "", file_name: str = None) -> str: os.makedirs(os.path.dirname(path), exist_ok=True) with open(path, "wb") as f: - f.write(requests.get(url).content) + f.write(response.content) - return path \ No newline at end of file + return path