In JavaScriptEngineSwitcher.ChakraCore in some parts of the code now are used a Javascript String values instead of the ArrayBuffer objects

Author: Taritsyn

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsContext.cs

@@ -1,13 +1,4 @@
 using System;
-using System.Runtime.CompilerServices;
-#if NET45 || NET471 || NETSTANDARD || NETCOREAPP2_1
-using System.Runtime.InteropServices;
-#endif
-using System.Text;
-#if NET40
-
-using PolyfillsForOldDotNet.System.Runtime.InteropServices;
-#endif
 
 namespace JavaScriptEngineSwitcher.ChakraCore.JsRt
 {
@@ -165,7 +156,7 @@ public static uint Idle()
 		public static JsValue ParseScript(string script, JsSourceContext sourceContext, string sourceUrl,
 			ref JsParseScriptAttributes parseAttributes)
 		{
-			JsValue scriptValue = CreateExternalArrayBufferFromScriptCode(script, ref parseAttributes);
+			JsValue scriptValue = JsValue.FromString(script);
 			scriptValue.AddRef();
 
 			JsValue sourceUrlValue = JsValue.FromString(sourceUrl);
@@ -244,7 +235,7 @@ public static JsValue ParseSerializedScript(string script, byte[] buffer,
 		public static JsValue RunScript(string script, JsSourceContext sourceContext, string sourceUrl,
 			ref JsParseScriptAttributes parseAttributes)
 		{
-			JsValue scriptValue = CreateExternalArrayBufferFromScriptCode(script, ref parseAttributes);
+			JsValue scriptValue = JsValue.FromString(script);
 			scriptValue.AddRef();
 
 			JsValue sourceUrlValue = JsValue.FromString(sourceUrl);
@@ -326,7 +317,7 @@ public static JsValue RunSerializedScript(string script, byte[] buffer,
 		/// <returns>The buffer to put the serialized script into</returns>
 		public static byte[] SerializeScript(string script, ref JsParseScriptAttributes parseAttributes)
 		{
-			JsValue scriptValue = CreateExternalArrayBufferFromScriptCode(script, ref parseAttributes);
+			JsValue scriptValue = JsValue.FromString(script);
 			scriptValue.AddRef();
 
 			JsValue bufferValue;
@@ -346,33 +337,6 @@ public static byte[] SerializeScript(string script, ref JsParseScriptAttributes
 			return buffer;
 		}
 
-		/// <summary>
-		/// Creates a Javascript <c>ArrayBuffer</c> object from script code
-		/// </summary>
-		/// <param name="script">Script code</param>
-		/// <param name="parseAttributes">Attribute mask for parsing the script</param>
-		/// <returns>The new <c>ArrayBuffer</c> object</returns>
-		[MethodImpl((MethodImplOptions)256 /* AggressiveInlining */)]
-		private static JsValue CreateExternalArrayBufferFromScriptCode(string script,
-			ref JsParseScriptAttributes parseAttributes)
-		{
-			Encoding encoding;
-
-			if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-			{
-				encoding = Encoding.Unicode;
-				parseAttributes |= JsParseScriptAttributes.ArrayBufferIsUtf16Encoded;
-			}
-			else
-			{
-				encoding = Encoding.UTF8;
-			}
-
-			JsValue scriptValue = JsValue.CreateExternalArrayBuffer(script, encoding);
-
-			return scriptValue;
-		}
-
 		/// <summary>
 		/// Returns a exception that caused the runtime of the current context to be in the
 		/// exception state and resets the exception state for that runtime

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsValue.cs

@@ -469,45 +469,6 @@ public static JsValue CreateExternalArrayBuffer(byte[] buffer)
 			return reference;
 		}
 
-		/// <summary>
-		/// Creates a Javascript <c>ArrayBuffer</c> object to access external memory
-		/// </summary>
-		/// <remarks>Requires an active script context.</remarks>
-		/// <param name="value">String value</param>
-		/// <param name="encoding">Character encoding</param>
-		/// <returns>The new <c>ArrayBuffer</c> object</returns>
-		public static unsafe JsValue CreateExternalArrayBuffer(string value, Encoding encoding)
-		{
-			if (value == null)
-			{
-				throw new ArgumentNullException(nameof(value));
-			}
-
-			if (encoding == null)
-			{
-				throw new ArgumentNullException(nameof(encoding));
-			}
-
-			int valueLength = value.Length;
-			int bufferLength = encoding.GetByteCount(value);
-			IntPtr bufferPtr = Marshal.AllocHGlobal(bufferLength + 1);
-
-			fixed (char* pValue = value)
-			{
-				var pBuffer = (byte*)bufferPtr;
-				pBuffer[bufferLength] = 0;
-
-				encoding.GetBytes(pValue, valueLength, pBuffer, bufferLength);
-			}
-
-			JsValue reference;
-			JsErrorCode errorCode = NativeMethods.JsCreateExternalArrayBuffer(bufferPtr, (uint)bufferLength,
-				DefaultExternalBufferFinalizeCallback.Instance, bufferPtr, out reference);
-			JsErrorHelpers.ThrowIfError(errorCode);
-
-			return reference;
-		}
-
 		/// <summary>
 		/// Creates a new JavaScript error object
 		/// </summary>