Undesired access gain between 2 instances of different types.

[PedroUrday]

Hi @TremayneChrist

I have found an error when there are two or more instances of different types. The error can be described with the next source code example:

function A() {}
function B() {}

A.prototype.public = function (b) {
    console.log("Called A public method");
    b.public(this);
};

B.prototype.public = function (a) {
    console.log("Called B public method");
    a._private(this);
};

A.prototype._private = function (b) {
    console.log("Called A private method. It should not pass :(");
    b._private(this);
};

B.prototype._private = function (a) {
    console.log("Called B private method. It too should not pass :(");
};

protect(A);
protect(B);

var a = new A();
var b = new B();

a.public(b);

I try to solve this without success! I'm checking my own fork. I tried with the proxy pattern (https://en.wikipedia.org/wiki/Proxy_pattern) but I think that leads to more problems.

Best regards!

[TremayneChrist]

@PedroUrday can you confirm you are using this version or higher
https://github.com/TremayneChrist/ProtectJS/releases/tag/v3.0.1

[PedroUrday]

@TremayneChrist
I tried it also with version 3.0.1 and the error persists.

[TremayneChrist]

Sorry I should have looked at your code more :)

Yes, they do have access. In your example however, both of the objects have to be involved in the misuse.

This does point out another problem though, synchronous callbacks.

function MyObject () {}

MyObject.prototype.public = function (cb) {
  if (typeof cb === 'function') return cb();
}

MyObject.prototype._private = function () {
  console.log('Oops!');
}

protect(MyObject);

var obj = new MyObject();

obj.public(function () {
  obj._private();
});