Commit 5841d3f
committed
fix: code review bugs + bump both packages to 1.6.0
Bug fixes (critical):
- callbacks.py: add ABC to UiPathDynamicHeadersCallback so @AbstractMethod
is enforced — previously the class could be instantiated without implementing
get_headers(), silently deferring the error to runtime
- clients/anthropic/chat_models.py: make vendor_type a required field (no default)
and seed api_config with VendorType.VERTEXAI as placeholder; the old default of
VendorType.ANTHROPIC caused the model validator to immediately raise ValueError,
making the class impossible to construct directly; also removed dead
VendorType.ANTHROPIC / VendorType.AZURE branches from _anthropic_client and
_async_anthropic_client that could never be reached, and unused imports
- clients/bedrock/utils.py: fix json.loads(kwargs.get('body', {})) — passing a
dict as default caused TypeError since json.loads requires str/bytes; changed
default to '{}' string; also corrected converse() and converse_stream()
system parameter type annotation from str|None to list[dict[str,Any]]|None to
match the list[dict] value langchain-aws actually passes
- clients/normalized/chat_models.py: add 'stream': True to request body in
_uipath_stream and _uipath_astream — without it the server returns a regular
non-streaming JSON response instead of SSE; fix fragile SSE prefix stripping
from chunk.split('data:')[1] (splits on all occurrences) to
chunk[len('data:'):].strip(); fix _generate_chunk to set text=content or ''
instead of text=original_message (raw JSON wire data)
- factory.py: replace bare model_info['vendor'] key access in get_embedding_model
with model_info.get('vendor') + explicit ValueError, matching the safe pattern
already used in get_chat_model
Bug fixes (minor):
- base_client.py: correct return type annotations on _astream, _uipath_astream,
and uipath_astream from AsyncIterator to AsyncGenerator (these are async
generator functions that contain yield, not plain iterables)
- demo.py: replace unsafe eval(expression) with an AST-based arithmetic-only
evaluator to prevent arbitrary code execution via LLM-generated input
Version bumps:
- packages/uipath_langchain_client: 1.5.10 -> 1.6.0
- src/uipath/llm_client: 1.5.10 -> 1.6.01 parent a01f0cf commit 5841d3f
9 files changed
Lines changed: 65 additions & 63 deletions
File tree
- packages/uipath_langchain_client
- src/uipath_langchain_client
- clients
- anthropic
- bedrock
- normalized
- src/uipath/llm_client
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
139 | 140 | | |
140 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
141 | 153 | | |
142 | 154 | | |
143 | 155 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
282 | 282 | | |
283 | 283 | | |
284 | 284 | | |
285 | | - | |
| 285 | + | |
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
| |||
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
426 | | - | |
| 426 | + | |
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
| 446 | + | |
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
Lines changed: 17 additions & 43 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | 18 | | |
20 | | - | |
21 | 19 | | |
22 | | - | |
23 | 20 | | |
24 | | - | |
25 | 21 | | |
26 | 22 | | |
27 | 23 | | |
| |||
33 | 29 | | |
34 | 30 | | |
35 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
55 | | - | |
| 56 | + | |
| 57 | + | |
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| |||
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | | - | |
| 69 | + | |
68 | 70 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | 71 | | |
86 | 72 | | |
87 | 73 | | |
| |||
103 | 89 | | |
104 | 90 | | |
105 | 91 | | |
106 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
107 | 95 | | |
108 | 96 | | |
109 | 97 | | |
110 | 98 | | |
111 | | - | |
| 99 | + | |
112 | 100 | | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | 101 | | |
130 | 102 | | |
131 | 103 | | |
| |||
147 | 119 | | |
148 | 120 | | |
149 | 121 | | |
150 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
151 | 125 | | |
152 | 126 | | |
153 | 127 | | |
| |||
Lines changed: 12 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
83 | 87 | | |
84 | 88 | | |
85 | 89 | | |
| |||
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
98 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
99 | 107 | | |
100 | 108 | | |
101 | 109 | | |
| |||
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
380 | | - | |
| 380 | + | |
381 | 381 | | |
382 | 382 | | |
383 | | - | |
| 383 | + | |
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
| 397 | + | |
397 | 398 | | |
398 | 399 | | |
399 | 400 | | |
400 | 401 | | |
401 | 402 | | |
402 | | - | |
| 403 | + | |
403 | 404 | | |
404 | 405 | | |
405 | 406 | | |
| |||
414 | 415 | | |
415 | 416 | | |
416 | 417 | | |
417 | | - | |
| 418 | + | |
418 | 419 | | |
| 420 | + | |
419 | 421 | | |
420 | 422 | | |
421 | 423 | | |
422 | 424 | | |
423 | 425 | | |
424 | | - | |
| 426 | + | |
425 | 427 | | |
426 | 428 | | |
427 | 429 | | |
| |||
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
301 | | - | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
302 | 308 | | |
303 | 309 | | |
304 | 310 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
0 commit comments