Skip to content

Conversation

@lowasser
Copy link
Collaborator

Builds on some material from #1712 .

@lowasser lowasser marked this pull request as ready for review December 4, 2025 01:13
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! My comments mostly regard naming of certain entries and file organization.

(f : type-function-Metric-Space X Y)
where

is-pointwise-continuous-prop-function-Metric-Space : Prop (l1 ⊔ l2 ⊔ l4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-pointwise-continuous-prop-function-Metric-Space : Prop (l1 ⊔ l2 ⊔ l4)
is-pointwise-continuous-prop-map-Metric-Space : Prop (l1 ⊔ l2 ⊔ l4)

(f : type-function-Metric-Space X Y)
where

is-classically-pointwise-continuous-prop-function-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-classically-pointwise-continuous-prop-function-Metric-Space :
is-classically-pointwise-continuous-prop-map-Metric-Space :

where

abstract
is-pointwise-continuous-is-classically-pointwise-continuous-ACω-function-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-pointwise-continuous-is-classically-pointwise-continuous-ACω-function-Metric-Space :
is-pointwise-continuous-is-classically-pointwise-continuous-map-acω-Metric-Space :

(y : type-Metric-Space Y)
where

is-classical-limit-prop-function-Metric-Space : Prop (l1 ⊔ l2 ⊔ l4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-classical-limit-prop-function-Metric-Space : Prop (l1 ⊔ l2 ⊔ l4)
is-classical-limit-prop-map-Metric-Space : Prop (l1 ⊔ l2 ⊔ l4)

where

abstract
is-classical-limit-is-limit-function-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-classical-limit-is-limit-function-Metric-Space :
is-classical-limit-is-limit-map-Metric-Space :

where

abstract
is-limit-is-classical-limit-ACω-function-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-limit-is-classical-limit-ACω-function-Metric-Space :
is-limit-is-classical-limit-map-acω-Metric-Space :

( leq-right-min-ℚ⁺ (μf ε) (μg ε))
( Ncc'))))

product-pointwise-continuous-map-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
product-pointwise-continuous-map-Metric-Space :
pointwise-continuous-map-product-Metric-Space :

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compare to equiv-product. This should be seen as a functorial action of products.

is-pointwise-continuous-is-isometry-Metric-Space X X id
( is-isometry-id-Metric-Space X)

pointwise-continuous-id-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pointwise-continuous-id-Metric-Space :
id-pointwise-continuous-map-Metric-Space :

where

abstract
is-pointwise-continuous-id-Metric-Space :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is-pointwise-continuous-id-Metric-Space :
is-pointwise-continuous-map-id-Metric-Space :

is-pointwise-continuous-is-short-function-Metric-Space X Y _
( is-short-constant-function-Metric-Space X Y y)

pointwise-continuous-constant-function-Metric-Space :
Copy link
Collaborator

@fredrik-bakke fredrik-bakke Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const-pointwise-continuous-map

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the predefined const function in your definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants