Skip to content

Conversation

@malarbol
Copy link
Collaborator

@malarbol malarbol commented Dec 1, 2025

This PR introduces the new modules:

  • action-on-cauchy-approximations-isometries-pseudometric-spaces.lagda.md;
  • action-on-cauchy-approximations-short-maps-metric-spaces.lagda.md;
  • action-on-cauchy-approximations-short-maps-pseudometric-spaces.lagda.md.

to refactor these concepts in their own modules.

malarbol and others added 25 commits November 22, 2025 18:28
…dometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
--lossy-unification breaks some proof of UniMath#1726
@malarbol
Copy link
Collaborator Author

malarbol commented Dec 1, 2025

Because we didn't have Cauchy pseudocompletions at the time, the definitions of these actions were in the cauchy-approximations-XXX modules while the fact that they induce short maps / isometries were in the cauchy-pseudocompletions-XXX modules.

@malarbol malarbol changed the title Refactor function actions cauchy approximations Refactor function actions on cauchy approximations Dec 2, 2025
( metric-quotient-Pseudometric-Space M))
short-map-metric-quotient-cauchy-apprtoximation-Pseudometric-Space =
short-map-short-function-cauchy-approximation-Pseudometric-Space
short-map-cauchy-approximation-short-function-Pseudometric-Space
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this highlights that short-function should be renamed to short-map

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to fix the problem short-function/short-map in another PR but I fixed the name of this function to short-map-cauchy-approximation-metric-quotient-Pseudometric-Space which seemed better. Is that ok?

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're already taking the opportunity to fix some names across the board, would you be so kind to also change the naming pattern short-function- to short-map-?

@malarbol
Copy link
Collaborator Author

malarbol commented Dec 5, 2025

Since you're already taking the opportunity to fix some names across the board, would you be so kind to also change the naming pattern short-function- to short-map-?

There are ~500 occurrences of short-function- across ~50 modules, so I think it would be better to do this change in a dedicated PR or in the same PR dedicated to #1621 with a coherent naming scheme between short maps and expansive maps.

malarbol and others added 14 commits December 5, 2025 17:54
…s-pseudometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-metric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-pseudometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-pseudometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-metric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-pseudometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…tions-of-pseudometric-spaces.lagda.md

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants