-
Notifications
You must be signed in to change notification settings - Fork 91
Refactor function actions on cauchy approximations #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor function actions on cauchy approximations #1738
Conversation
…dometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…dometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
--lossy-unification breaks some proof of UniMath#1726
|
Because we didn't have Cauchy pseudocompletions at the time, the definitions of these actions were in the |
src/metric-spaces/action-of-short-maps-on-cauchy-approximations-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/action-of-short-maps-on-cauchy-approximations-pseudometric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
| ( metric-quotient-Pseudometric-Space M)) | ||
| short-map-metric-quotient-cauchy-apprtoximation-Pseudometric-Space = | ||
| short-map-short-function-cauchy-approximation-Pseudometric-Space | ||
| short-map-cauchy-approximation-short-function-Pseudometric-Space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this highlights that short-function should be renamed to short-map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to fix the problem short-function/short-map in another PR but I fixed the name of this function to short-map-cauchy-approximation-metric-quotient-Pseudometric-Space which seemed better. Is that ok?
src/metric-spaces/cauchy-pseudocompletion-of-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/action-of-short-maps-on-cauchy-approximations-pseudometric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/action-on-cauchy-approximations-short-maps-pseudometric-spaces.lagda.md
Show resolved
Hide resolved
src/metric-spaces/action-of-short-maps-on-cauchy-approximations-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/action-on-cauchy-approximations-short-maps-metric-spaces.lagda.md
Show resolved
Hide resolved
src/metric-spaces/action-on-cauchy-approximations-isometries-pseudometric-spaces.lagda.md
Show resolved
Hide resolved
src/metric-spaces/action-on-cauchy-approximations-isometries-pseudometric-spaces.lagda.md
Show resolved
Hide resolved
...ric-spaces/cauchy-approximations-in-cauchy-pseudocompletions-of-pseudometric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
...ric-spaces/cauchy-approximations-in-cauchy-pseudocompletions-of-pseudometric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
...ric-spaces/cauchy-approximations-in-cauchy-pseudocompletions-of-pseudometric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
fredrik-bakke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're already taking the opportunity to fix some names across the board, would you be so kind to also change the naming pattern short-function- to short-map-?
There are ~500 occurrences of |
…s-pseudometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-metric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-pseudometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-pseudometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-metric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…s-pseudometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
…tions-of-pseudometric-spaces.lagda.md Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
This PR introduces the new modules:
action-on-cauchy-approximations-isometries-pseudometric-spaces.lagda.md;action-on-cauchy-approximations-short-maps-metric-spaces.lagda.md;action-on-cauchy-approximations-short-maps-pseudometric-spaces.lagda.md.to refactor these concepts in their own modules.