Add BNTL utility plugin #1260
emesarerust.yml
on: push
cargo clippy
4m 49s
cargo fmt
4m 20s
typos
10s
licensing
4m 15s
Annotations
11 errors and 1 warning
|
licensing
Process completed with exit code 1.
|
|
casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`):
rust/src/types/parser.rs#L161
error: casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`)
--> rust/src/types/parser.rs:161:17
|
161 | include_directories_raw.as_ptr() as *const *const c_char,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_directories_raw.as_ptr()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast
|
|
casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`):
rust/src/types/parser.rs#L159
error: casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`)
--> rust/src/types/parser.rs:159:17
|
159 | options_raw.as_ptr() as *const *const c_char,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `options_raw.as_ptr()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`:
rust/src/types/parser.rs#L143
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> rust/src/types/parser.rs:143:14
|
143 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#into_iter_on_ref
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`:
rust/src/types/parser.rs#L140
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> rust/src/types/parser.rs:140:39
|
140 | let options: Vec<_> = options.into_iter().map(|o| o.to_cstr()).collect();
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#into_iter_on_ref
|
|
casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`):
rust/src/types/parser.rs#L111
error: casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`)
--> rust/src/types/parser.rs:111:17
|
111 | include_directories_raw.as_ptr() as *const *const c_char,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_directories_raw.as_ptr()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast
|
|
casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`):
rust/src/types/parser.rs#L109
error: casting raw pointers to the same type and constness is unnecessary (`*const *const i8` -> `*const *const i8`)
--> rust/src/types/parser.rs:109:17
|
109 | options_raw.as_ptr() as *const *const c_char,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `options_raw.as_ptr()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`:
rust/src/types/parser.rs#L94
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> rust/src/types/parser.rs:94:14
|
94 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#into_iter_on_ref
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`:
rust/src/types/parser.rs#L91
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> rust/src/types/parser.rs:91:39
|
91 | let options: Vec<_> = options.into_iter().map(|o| o.to_cstr()).collect();
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#into_iter_on_ref
= note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::into_iter_on_ref)]`
|
|
this creates an owned instance just for comparison:
rust/src/file_metadata.rs#L166
error: this creates an owned instance just for comparison
--> rust/src/file_metadata.rs:166:38
|
166 | match path.is_empty() || PathBuf::from(&path) == self.file_path() {
| ^^^^^^^^^^^^^^^^^^^^ help: try: `*&path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#cmp_owned
= note: `-D clippy::cmp-owned` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::cmp_owned)]`
|
|
called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator:
rust/src/file_metadata.rs#L104
error: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
--> rust/src/file_metadata.rs:104:9
|
104 | raw_name.split('/').last().unwrap_or(&raw_name).to_string()
| ^^^^^^^^^^^^^^^^^^^^------
| |
| help: try: `next_back()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#double_ended_iterator_last
= note: `-D clippy::double-ended-iterator-last` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::double_ended_iterator_last)]`
|
|
licensing
New version for cargo-about available: 0.8.4
|