Plugin crashes with 5.4.x versions of via*

[Kichura]

When starting this plugin on any server version, the plugin crashes because boundingBoxEastField is null.
Full logs can be found here.

[Techirion]

I think the issue is the fact that in...

public class LadderBlock extends Block implements SimpleWaterloggedBlock

    protected static final VoxelShape EAST_AABB = Block.box(0.0, 0.0, 0.0, 3.0, 16.0, 16.0);
    protected static final VoxelShape WEST_AABB = Block.box(13.0, 0.0, 0.0, 16.0, 16.0, 16.0);
    protected static final VoxelShape SOUTH_AABB = Block.box(0.0, 0.0, 0.0, 16.0, 16.0, 3.0);
    protected static final VoxelShape NORTH_AABB = Block.box(0.0, 0.0, 13.0, 16.0, 16.0, 16.0);

was replaced with

    public static final Map<Direction, VoxelShape> SHAPES = Shapes.rotateHorizontal(Block.boxZ(16.0, 13.0, 16.0));

which is also why

ViaRewind-Legacy-Support/src/main/java/com/viaversion/viarewind/legacysupport/feature/BlockCollisionChanges.java

Line 76 in b6f89c9

logger.log(Level.SEVERE, "Could not fix ladder bounding box.", ex);

is shown in logs...

[Kichura]

I think the issue is the fact that in...

public class LadderBlock extends Block implements SimpleWaterloggedBlock

    protected static final VoxelShape EAST_AABB = Block.box(0.0, 0.0, 0.0, 3.0, 16.0, 16.0);
    protected static final VoxelShape WEST_AABB = Block.box(13.0, 0.0, 0.0, 16.0, 16.0, 16.0);
    protected static final VoxelShape SOUTH_AABB = Block.box(0.0, 0.0, 0.0, 16.0, 16.0, 3.0);
    protected static final VoxelShape NORTH_AABB = Block.box(0.0, 0.0, 13.0, 16.0, 16.0, 16.0);

was replaced with

    public static final Map<Direction, VoxelShape> SHAPES = Shapes.rotateHorizontal(Block.boxZ(16.0, 13.0, 16.0));

which is also why

ViaRewind-Legacy-Support/src/main/java/com/viaversion/viarewind/legacysupport/feature/BlockCollisionChanges.java

Line 76 in b6f89c9
logger.log(Level.SEVERE, "Could not fix ladder bounding box.", ex);

is shown in logs...

Can you make a PR to that and test it?

[Techirion]

Should also be mentioned it doesn't crash but just fails to fix bounding boxes, and it's only cause 1.21.5+ changed internals, unrelated to Via plugins. I did a few tests with my PR and 1.8.8 and 1.21.8 clients (on 1.21.7 Paper) and Ladders are working as expected.