Skip to content

Commit a58895d

Browse files
authored
Merge pull request #160 from WalletConnect/bugfix/bugfixes_and_improvements
Bug fixes and improvements
2 parents 630950f + a7cf86e commit a58895d

28 files changed

Lines changed: 574 additions & 313 deletions

File tree

.github/workflows/publish.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
name: Publish to pub.dev
22

33
on:
4-
workflow_dispatch:
54
push:
65
tags:
76
- 'v[0-9]+.[0-9]+.[0-9]+*'
@@ -12,7 +11,6 @@ jobs:
1211
permissions:
1312
id-token: write
1413
runs-on: ubuntu-latest
15-
1614
steps:
1715
# Checkout the repo
1816
- uses: actions/checkout@v3

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
## 3.3.0-beta06
1+
## 3.3.0
22

33
- One-Click Auth + SIWE implementation
44
- Coinbase Wallet dependency update
5-
- Bug fixes
5+
- Bug fixes and improvements
66

77
## 3.2.2
88

example/android/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
<package android:name="kh.com.sabay.sabaywallet"/>
5050
<package android:name="com.tokoin.wallet"/>
5151
<package android:name="com.walletconnect.flutterwallet"/>
52+
<package android:name="com.walletconnect.flutterwallet.internal"/>
5253
<package android:name="com.walletconnect.web3wallet.rnsample"/>
5354
<package android:name="com.walletconnect.sample.wallet"/>
5455
<package android:name="com.walletconnect.sample.wallet.internal"/>

example/android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ org.gradle.jvmargs=-Xmx1536M
22
android.useAndroidX=true
33
android.enableJetifier=true
44
versionName=3.3.0
5-
versionCode=67
5+
versionCode=71

example/ios/Podfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,4 @@ SPEC CHECKSUMS:
7878

7979
PODFILE CHECKSUM: a57f30d18f102dd3ce366b1d62a55ecbef2158e5
8080

81-
COCOAPODS: 1.13.0
81+
COCOAPODS: 1.15.2

example/ios/Runner.xcodeproj/project.pbxproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@
470470
CLANG_ENABLE_MODULES = YES;
471471
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
472472
CODE_SIGN_STYLE = Manual;
473-
CURRENT_PROJECT_VERSION = 67;
473+
CURRENT_PROJECT_VERSION = 70;
474474
DEVELOPMENT_TEAM = "";
475475
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = W5R8AG9K22;
476476
ENABLE_BITCODE = NO;
@@ -496,7 +496,7 @@
496496
buildSettings = {
497497
BUNDLE_LOADER = "$(TEST_HOST)";
498498
CODE_SIGN_STYLE = Automatic;
499-
CURRENT_PROJECT_VERSION = 67;
499+
CURRENT_PROJECT_VERSION = 70;
500500
GENERATE_INFOPLIST_FILE = YES;
501501
MARKETING_VERSION = 1.0;
502502
PRODUCT_BUNDLE_IDENTIFIER = com.web3modal.flutterExample.RunnerTests;
@@ -514,7 +514,7 @@
514514
buildSettings = {
515515
BUNDLE_LOADER = "$(TEST_HOST)";
516516
CODE_SIGN_STYLE = Automatic;
517-
CURRENT_PROJECT_VERSION = 67;
517+
CURRENT_PROJECT_VERSION = 70;
518518
GENERATE_INFOPLIST_FILE = YES;
519519
MARKETING_VERSION = 1.0;
520520
PRODUCT_BUNDLE_IDENTIFIER = com.web3modal.flutterExample.RunnerTests;
@@ -530,7 +530,7 @@
530530
buildSettings = {
531531
BUNDLE_LOADER = "$(TEST_HOST)";
532532
CODE_SIGN_STYLE = Automatic;
533-
CURRENT_PROJECT_VERSION = 67;
533+
CURRENT_PROJECT_VERSION = 70;
534534
GENERATE_INFOPLIST_FILE = YES;
535535
MARKETING_VERSION = 1.0;
536536
PRODUCT_BUNDLE_IDENTIFIER = com.web3modal.flutterExample.RunnerTests;
@@ -655,7 +655,7 @@
655655
CLANG_ENABLE_MODULES = YES;
656656
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
657657
CODE_SIGN_STYLE = Manual;
658-
CURRENT_PROJECT_VERSION = 67;
658+
CURRENT_PROJECT_VERSION = 70;
659659
DEVELOPMENT_TEAM = "";
660660
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = W5R8AG9K22;
661661
ENABLE_BITCODE = NO;
@@ -686,7 +686,7 @@
686686
CODE_SIGN_IDENTITY = "Apple Development";
687687
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
688688
CODE_SIGN_STYLE = Manual;
689-
CURRENT_PROJECT_VERSION = 67;
689+
CURRENT_PROJECT_VERSION = 70;
690690
DEVELOPMENT_TEAM = "";
691691
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = W5R8AG9K22;
692692
ENABLE_BITCODE = NO;

example/ios/Runner/Info.plist

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
</dict>
3737
</array>
3838
<key>CFBundleVersion</key>
39-
<string>67</string>
39+
<string>70</string>
4040
<key>ITSAppUsesNonExemptEncryption</key>
4141
<false/>
4242
<key>LSApplicationQueriesSchemes</key>
@@ -82,14 +82,13 @@
8282
<string>trust</string>
8383
<string>thorwallet</string>
8484
<string>krakenwallet</string>
85-
<string>cosmostation</string>
8685
<string>coinwallet</string>
8786
<string>mewwallet</string>
8887
<string>metamask</string>
8988
<string>avacus</string>
90-
<string>argent</string>
9189
<string>walletapp</string>
92-
<string>wcflutterwallet</string>
90+
<string>wcflutterwallet-production</string>
91+
<string>wcflutterwallet-internal</string>
9392
<string>rn-web3wallet</string>
9493
</array>
9594
<key>LSRequiresIPhoneOS</key>

example/lib/home_page.dart

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class _MyHomePageState extends State<MyHomePage> {
5454
],
5555
redirect: Redirect(
5656
native: 'web3modalflutter://',
57-
universal: 'https://walletconnect.com/appkit',
57+
// universal: 'https://walletconnect.com/appkit',
5858
),
5959
);
6060

@@ -74,7 +74,7 @@ class _MyHomePageState extends State<MyHomePage> {
7474
getMessageParams: () async {
7575
// Provide everything that is needed to construct the SIWE message
7676
debugPrint('[SIWEConfig] getMessageParams()');
77-
final uri = Uri.parse(_pairingMetadata.redirect!.universal!);
77+
final uri = Uri.parse(_pairingMetadata.redirect!.native!);
7878
return SIWEMessageArgs(
7979
domain: uri.authority,
8080
uri: 'https://walletconnect.com/login',
@@ -93,7 +93,7 @@ class _MyHomePageState extends State<MyHomePage> {
9393
try {
9494
debugPrint('[SIWEConfig] verifyMessage()');
9595
final payload = args.toJson();
96-
final uri = Uri.parse(_pairingMetadata.redirect!.universal!);
96+
final uri = Uri.parse(_pairingMetadata.redirect!.native!);
9797
final result = await _siweTestService.verifyMessage(
9898
payload,
9999
domain: uri.authority,
@@ -253,9 +253,9 @@ class _MyHomePageState extends State<MyHomePage> {
253253
super.dispose();
254254
}
255255

256-
void _onModalConnect(ModalConnect? event) {
257-
debugPrint('[ExampleApp] _onModalConnect ${event?.toString()}');
256+
void _onModalConnect(ModalConnect? event) async {
258257
setState(() {});
258+
debugPrint('[ExampleApp] _onModalConnect ${event?.session.toJson()}');
259259
}
260260

261261
void _onModalUpdate(ModalConnect? event) {
@@ -304,8 +304,8 @@ class _MyHomePageState extends State<MyHomePage> {
304304
}
305305

306306
void _onRelayClientError(EventArgs? event) {
307-
debugPrint('[ExampleApp] _onRelayClientError ${event?.toString()}');
308307
setState(() {});
308+
showTextToast(text: 'Relay disconnected', context: context);
309309
}
310310

311311
void _onRelayClientDisconnect(EventArgs? event) {
@@ -364,13 +364,20 @@ class _MyHomePageState extends State<MyHomePage> {
364364
},
365365
);
366366
},
367+
floatingActionButton: CircleAvatar(
368+
radius: 6.0,
369+
backgroundColor: _initialized &&
370+
_w3mService.web3App?.core.relayClient.isConnected == true
371+
? Colors.green
372+
: Colors.red,
373+
),
367374
);
368375
}
369376

370377
Future<void> _refreshData() async {
378+
await _w3mService.reconnectRelay();
371379
await _w3mService.loadAccountData();
372380
setState(() {});
373-
return;
374381
}
375382
}
376383

example/lib/widgets/debug_drawer.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ class _DebugDrawerState extends State<DebugDrawer> with WidgetsBindingObserver {
249249
),
250250
onTap: () {
251251
if (_hasUpdates) {
252-
// TODO warn and crash!
253252
showDialog(
254253
context: context,
255254
builder: (BuildContext context) {

example/lib/widgets/session_widget.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ class SessionWidgetState extends State<SessionWidget> {
375375
[
376376
const SizedBox(height: StyleConstants.linear8),
377377
Text(
378-
'Supported chains:',
378+
'Session chains:',
379379
style: Web3ModalTheme.getDataOf(context).textStyles.small600.copyWith(
380380
color: Web3ModalTheme.colorsOf(context).foreground100,
381381
),

0 commit comments

Comments
 (0)