Skip to content

Commit 394ca17

Browse files
Update release action to use ncipollo/release-action and adjust conditions for generating release notes
1 parent 8bee792 commit 394ca17

1 file changed

Lines changed: 22 additions & 12 deletions

File tree

.github/workflows/powershell-build-module.yml

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ jobs:
121121
- name: Generate release notes
122122
shell: pwsh
123123
id: generate_release_notes
124-
if: github.ref_name == 'main' && github.event_name == 'workflow_dispatch'
124+
if: github.ref_name == 'main' && (github.event_name == 'workflow_dispatch' || github.event_name == 'push')
125125
env:
126126
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
127127
run: |
@@ -153,19 +153,29 @@ jobs:
153153
Write-Output ($result.body.ToString()) >> $env:GITHUB_OUTPUT
154154
Write-Output 'EOF' >> $env:GITHUB_OUTPUT
155155
156-
- name: Create Release
157-
id: create_release
158-
uses: actions/create-release@0cb9c9b65d5d1901c1f53e5e66eaf4afd303e70e #v1.1.4
159-
if: github.ref_name == 'main' && (github.event_name == 'workflow_dispatch' || github.event_name == 'push')
160-
env:
161-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
156+
#- name: Create Release
157+
# id: create_release
158+
# uses: actions/create-release@0cb9c9b65d5d1901c1f53e5e66eaf4afd303e70e #v1.1.4
159+
# if: github.ref_name == 'main' && (github.event_name == 'workflow_dispatch' || github.event_name == 'push')
160+
# env:
161+
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
162+
# with:
163+
# tag_name: v${{ env.majorMinorPatch }}
164+
# release_name: Release v${{ env.majorMinorPatch }}
165+
# body: |
166+
# ${{ steps.generate_release_notes.outputs.releaseNotes }}
167+
# draft: false
168+
# prerelease: ${{ env.releaseType == 'Prerelease' }}
169+
170+
- name: Create release
171+
uses: ncipollo/release-action@v1
162172
with:
163-
tag_name: v${{ env.majorMinorPatch }}
164-
release_name: Release ${{ env.releaseVersion }}
165-
body: |
166-
${{ steps.generate_release_notes.outputs.releaseNotes }}
167-
draft: false
173+
name: Release v${{ env.majorMinorPatch }}
174+
tag: v${{ env.majorMinorPatch }}
175+
body: ${{ steps.generate_release_notes.outputs.releaseNotes }}
168176
prerelease: ${{ env.releaseType == 'Prerelease' }}
177+
allowUpdates: true
178+
169179

170180
- name: Commit generated help
171181
if: github.ref_name == 'main' && github.event_name == 'push'

0 commit comments

Comments
 (0)