🐛 Improve API responses

Author: Beelzenef

TaleEngine/TaleEngine.Bussiness/Queries/EditionQueries.cs

@@ -36,7 +36,7 @@ public EditionDaysDto EditionDaysQuery(int editionId)
         }
 
         public List<EditionDto> EditionsQuery(int eventId) {
-            if (eventId == 0) throw new ArgumentNullException();
+            if (eventId == 0) return null;
 
             var editionsOfEvent = _service.GetEditions(eventId);
 
@@ -53,7 +53,7 @@ public List<EditionDto> EditionsQuery(int eventId) {
 
         public int FutureOrCurrentEditionQuery(int ofEvent)
         {
-            if (ofEvent == 0) throw new ArgumentNullException();
+            if (ofEvent == 0) return 0;
 
             var editionsOfEvent = _service.GetEditions(ofEvent);
 

TaleEngine/TaleEngine/Controllers/Backoffice/RolesController.cs

@@ -60,6 +60,12 @@ public IActionResult GetAllRoles()
         public IActionResult GetRole(int roleId)
         {
             var result = query.GetRoleQuery(roleId);
+
+            if (result == null)
+            {
+                return NoContent();
+            }
+
             return Ok(result);
         }
 

TaleEngine/TaleEngine/Controllers/Backoffice/UserController.cs

@@ -22,6 +22,11 @@ public IActionResult GetAllUsers()
         {
             var result = _queries.AllUsersQuery();
 
+            if (result == null || result.Count == 0)
+            {
+                return NoContent();
+            }
+
             return Ok(result);
         }
 

TaleEngine/TaleEngine/Controllers/V1/EventController.cs

@@ -1,4 +1,5 @@
-using Microsoft.AspNetCore.Mvc;
+using System;
+using Microsoft.AspNetCore.Mvc;
 using TaleEngine.CQRS.Contracts;
 
 namespace TaleEngine.API.Controllers.V1
@@ -11,14 +12,19 @@ public class EventController : Controller
 
         public EventController(IEventQueries queries)
         {
-            _queries = queries;
+            _queries = queries ?? throw new ArgumentNullException(nameof(queries));
         }
 
         [HttpGet("[action]")]
         public IActionResult GetEvents()
         {
             var result = _queries.EventsNoFilterQuery();
 
+            if (result == null || result.Count == 0)
+            {
+                return NoContent();
+            }
+
             return Ok(result);
         }
 
@@ -27,13 +33,24 @@ public IActionResult GetEvent(int eventId)
         {
             var result = _queries.GetEvent(eventId);
 
+            if (result == null)
+            {
+                return NotFound();
+            }
+
             return Ok(result);
         }
 
         [HttpGet("[action]")]
-        public IActionResult GetCurrentEditionInEvent(int eventId) {
+        public IActionResult GetCurrentEditionInEvent(int eventId)
+        {
             var result = _queries.GetCurrentEdition(eventId);
 
+            if (result == null)
+            {
+                return NotFound();
+            }
+
             return Ok(result);
         }
     }