Skip to content

SignatureCalculator for ning client and new version #7

@vonagam

Description

@vonagam

As is seen here, ning removed url parameter from calculateAndAddSignature method in newer version of the library:

https://github.com/AsyncHttpClient/async-http-client/blob/1.9.x/src/main/java/com/ning/http/client/SignatureCalculator.java#L38

public void calculateAndAddSignature(String url, Request request, RequestBuilderBase<?> requestBuilder) {

As this parameter is not used in any way by AsyncSignatureCalculator it can be simply removed to support new interface.

Can http-helpers be updated with support for newer ning client version?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions