Skip to content

fix(examples/multi_platform_seller): list_creatives response missing required query_summary #510

@bokelley

Description

@bokelley

Summary

Both `MockGuaranteedPlatform` and `MockNonGuaranteedPlatform` in `examples/multi_platform_seller/` fail `list_creatives` storyboard validation because the response is missing the required `query_summary` field.

Failure (from PR #508 storyboard artifact, post-fix)

```
storyboard: media_buy_seller/creative_fate_after_cancellation
step: list_creatives_before_cancel
task: list_creatives
error: mcp_error: Output validation error: 'query_summary' is a required property
```

Both tenants hit this. 1 of the 4 remaining failures per tenant after PR #508's main mock-shape fixes; the other 3 are blocked on #509 (MCP error projection).

Fix

Look at the `list_creatives_response.json` schema in `src/adcp/types/generated_poc/bundled/creative/` — `query_summary` is a required field with totals/counts of the result set. The mocks need to populate it on every list_creatives response.

Should be a 5-line fix per platform.

Acceptance

  • Both mocks return `query_summary` on `list_creatives` responses
  • Storyboard `creative_fate_after_cancellation` step `list_creatives_before_cancel` passes for both tenants
  • Existing tests stay green

Refs

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions