decisioning: surface advertise_all=False on create_adcp_server_from_platform

[bokelley]

From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, item #14).

A fresh MockSellerPlatform with 5 methods shows ~50 entries in handler.advertised_tools after create_adcp_server_from_platform(). The advertise_all flag controls this but isn't surfaced in create_adcp_server_from_platform's signature — only in serve()/create_mcp_server.

So the standalone "build the handler" path doesn't have an obvious knob for "advertise only what I implement."

Ask

Add advertise_all=False (default) to create_adcp_server_from_platform's signature and have it filter advertised_tools to declared methods, matching serve()'s default.

Acceptance

handler = create_adcp_server_from_platform(platform=MyPlatform()).handler — handler.advertised_tools returns only methods the platform implements, without an extra kwarg.

Existing callers passing advertise_all=True continue to opt into the full spec surface.

[bokelley]

Triage

Classification: Feature request
Bucket(s): handlers
Status: drafting-pr
Milestone: omitted

What the experts said:

• code-reviewer: approved — get_tools_for_handler reads _HANDLER_TOOLS[cls.__name__] (ClassVar, set at class-definition time), so the instance attribute shadow and the MCP tools/list filter are entirely independent paths; no correctness risk.
• dx-expert: approved — advertise_all=False is the right default and matches serve()'s existing convention; noted the behavior change silently trims advertised_tools for existing build-path callers (desired, documented in PR).

My take: The gap is real: serve() already filtered tools/list via advertised_tools_for_instance(), but handler.advertised_tools on the standalone build path returned the full ~40-tool ClassVar union. One-line param addition + instance-level override after construction, with empty-set fallback so platforms using a novel specialism slug aren't accidentally muted. PR #528 is open as a draft.

Drafting PR: adds advertise_all: bool = False to create_adcp_server_from_platform(), overrides handler.advertised_tools at instance level when False, propagates the flag from serve() for consistency.

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01VYgrLhaR7HWfBf3VxbMn5K

---

Generated by Claude Code