docs(migration): note 161 figure is v4.0 worst case#539
Closed
docs(migration): note 161 figure is v4.0 worst case#539
Conversation
Salesagent re-run against v4.3+ (after expanded aliases + smaller-cascade warning) hit 141 findings and ~36 collection errors — markedly fewer. The 161 number gets quoted as if it's still representative; this callout points adopters at what to expect on v4.3+ while preserving the worst-case framing for adopters copying salesagent's pre-v4.3 pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as duplicate of #522 (triage-managed) which was opened first and covers the same docstring annotation. |
Contributor
Author
|
Acknowledged — closed as duplicate of #522 (triage-managed). No further action needed here. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #520.
Summary
Adds a callout block right after the "270 files scanned, 161 test-collection failures" line in
MIGRATION_v3_to_v4.mdnoting that:pending_activationcodemod flagger, and the_base.py-cascade warning landed) hit 141 codemod findings and ~36 collection errors.Preserves the original worst-case framing (it's still what adopters who copy salesagent's pre-v4.3 pattern will see) but tells v4.3+ adopters what to actually expect.
Why
Salesagent migration feedback #15: the figures "made me expect worse pain than I actually hit." The 4.x improvements between the prior attempt and now are working, and the guide should reflect that.
Test plan
core/SDK_FEEDBACK.mdadopter context)🤖 Generated with Claude Code