Skip to content

fix: update Identity Match response example — missing serve_window_sec field #4462

@AndyBevan

Description

@AndyBevan

Happy to fix this - I was taking a look at the repo, cloned and ran the tests and 1 fails, I don't see another PR fixing this. Below is what Claude generated for me.

Summary

Test suite fails with schema validation error: TMP Identity Match response example is missing the required serve_window_sec field introduced in #4070.

Error

❌ TMP Identity Match response — web (overview walkthrough): root: must have required property 'serve_window_sec'

Root Cause

Commit 91f417f8a ("spec(tmp): IdentityMatch frequency-cap data flow + serve_window_sec #4070) merged 2026-05-07 updated the schema in static/schemas/source/tmp/identity-match-response.json to:

  • Add serve_window_sec (required field, 1-300 seconds)
  • Remove ttl_sec (deprecated)

However, the test example in tests/example-validation-simple.test.cjs (line 584) was not updated and still references the old ttl_sec field.

Fix Required

File: tests/example-validation-simple.test.cjs
Line: 584

Change from:

await validateExample(
  {
    "type": "identity_match_response",
    "request_id": "id-7c9e1d",
    "eligible_package_ids": ["pkg-outdoor-audio"],
    "ttl_sec": 60
  },
  '/schemas/tmp/identity-match-response.json',
  'TMP Identity Match response — web (overview walkthrough)'
);

Change to:

await validateExample(
  {
    "type": "identity_match_response",
    "request_id": "id-7c9e1d",
    "eligible_package_ids": ["pkg-outdoor-audio"],
    "serve_window_sec": 60
  },
  '/schemas/tmp/identity-match-response.json',
  'TMP Identity Match response — web (overview walkthrough)'
);

Impact

  • Full test suite (npm test) fails and exits early
  • Blocks all downstream tests: extensions, migrations, unit tests, type checking
  • Test coverage: example validation tests 35/36 passing

Related Issues

Verification Steps

  1. Update tests/example-validation-simple.test.cjs line 584
  2. Run npm run test:examples — should show 36/36 passing
  3. Run npm test — should complete full suite without errors

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions