Test - add new slide urls for a non-deprecated bucket#454
Test - add new slide urls for a non-deprecated bucket#454
Conversation
…ervice account is able to reach Tests were failing due to a race condition. The test was expecting a run to be processing, but is was failing early due to a USER_ERROR caused by a signed url being created with the wrong permission set
| str, | ||
| typer.Argument( | ||
| help="URL to download." | ||
| " Example: gs://aignx-storage-service-dev/sample_data_formatted/9375e3ed-28d2-4cf3-9fb9-8df9d11a6627.tiff" |
There was a problem hiding this comment.
I'm unsure this will still work for a non aignx user
There was a problem hiding this comment.
Pull request overview
Updates test slide GCS URLs to point to a non-deprecated bucket, and aligns related user-facing examples/documentation strings in the dataset download CLI/service.
Changes:
- Update
SPOT_*_GS_URLconstants in tests to use the newgs://aignostics-platform-ext-a4f7e9/python-sdk-tests/he-tme/slides/...bucket path. - Refresh example URLs in dataset service docstring and CLI help text.
- Adjust
examples/script.pyto reuse slide constants (currently viatests.constants_test), and extend.gitignorefor local editor/config files.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/constants_test.py | Switches slide GCS URLs to the new non-deprecated bucket. |
| src/aignostics/dataset/_service.py | Updates docstring example to reflect the new bucket URL format. |
| src/aignostics/dataset/_cli.py | Updates CLI help example URL to the new bucket path. |
| examples/script.py | Replaces hardcoded slide metadata/URL with imported constants (currently from tests). |
| .gitignore | Ignores .vscode/* and **/settings.local.json local configuration files. |
| from tests.constants_test import ( | ||
| SPOT_1_CRC32C, | ||
| SPOT_1_GS_URL, | ||
| SPOT_1_HEIGHT, | ||
| SPOT_1_RESOLUTION_MPP, | ||
| SPOT_1_WIDTH, | ||
| ) | ||
|
|
There was a problem hiding this comment.
examples is packaged into the wheel (see pyproject.toml), but tests is not. Importing tests.constants_test will therefore raise ModuleNotFoundError for installed users running this example. Consider moving these shared slide constants into a runtime module (e.g., src/aignostics/...) or duplicating them locally within examples/ so the example is self-contained.
| from tests.constants_test import ( | |
| SPOT_1_CRC32C, | |
| SPOT_1_GS_URL, | |
| SPOT_1_HEIGHT, | |
| SPOT_1_RESOLUTION_MPP, | |
| SPOT_1_WIDTH, | |
| ) | |
| # Constants for the example slide; duplicated here so the example is self-contained | |
| # and does not depend on the uninstalled `tests` package. | |
| SPOT_1_CRC32C = "INSERT_BASE64_CRC32C_CHECKSUM_HERE" | |
| SPOT_1_GS_URL = "gs://INSERT_BUCKET_NAME/INSERT_OBJECT_PATH" | |
| SPOT_1_HEIGHT = 0 | |
| SPOT_1_RESOLUTION_MPP = 0.0 | |
| SPOT_1_WIDTH = 0 |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
|



Triggering a ci run here: https://github.com/aignostics/python-sdk/actions/runs/22497218409