From b20444eda2513824cf5084ca9b8f886d2391d21c Mon Sep 17 00:00:00 2001 From: Jianning Wang Date: Tue, 27 Jan 2026 11:36:13 +0800 Subject: [PATCH 1/5] hotfix: ci add make_all & fix local_builder --- .github/workflows/linux_x64_docker_ci.yml | 6 ++++++ .github/workflows/mac_arm64_ci.yml | 8 +++++++- tools/core/local_builder.cc | 2 ++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/workflows/linux_x64_docker_ci.yml b/.github/workflows/linux_x64_docker_ci.yml index 325e2191..e73a275f 100644 --- a/.github/workflows/linux_x64_docker_ci.yml +++ b/.github/workflows/linux_x64_docker_ci.yml @@ -130,3 +130,9 @@ jobs: cd "$CLEAN_WORKSPACE/build" make unittest -j$(nproc) shell: bash + + - name: Make All + run: | + cd "$CLEAN_WORKSPACE/build" + make all -j$(nproc) + shell: bash diff --git a/.github/workflows/mac_arm64_ci.yml b/.github/workflows/mac_arm64_ci.yml index b113f62d..6864ca49 100644 --- a/.github/workflows/mac_arm64_ci.yml +++ b/.github/workflows/mac_arm64_ci.yml @@ -96,4 +96,10 @@ jobs: run: | cd "$CLEAN_WORKSPACE/build" make unittest -j 16 - shell: bash \ No newline at end of file + shell: bash + + - name: Make All + run: | + cd "$CLEAN_WORKSPACE/build" + make all -j$(nproc) + shell: bash diff --git a/tools/core/local_builder.cc b/tools/core/local_builder.cc index 46f6c6da..9efc6b4a 100644 --- a/tools/core/local_builder.cc +++ b/tools/core/local_builder.cc @@ -18,6 +18,8 @@ #include #include #include +#include "algorithm/flat/flat_utility.h" +#include "algorithm/hnsw/hnsw_params.h" #include "zvec/core/framework/index_dumper.h" #include "zvec/core/framework/index_factory.h" #include "zvec/core/framework/index_logger.h" From 59ba6a3cf8c34de489bda323fdd308bbe1fafa25 Mon Sep 17 00:00:00 2001 From: Jianning Wang Date: Tue, 27 Jan 2026 12:42:41 +0800 Subject: [PATCH 2/5] try to fix pythonbinding error --- .github/workflows/linux_x64_docker_ci.yml | 3 ++- .github/workflows/mac_arm64_ci.yml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/linux_x64_docker_ci.yml b/.github/workflows/linux_x64_docker_ci.yml index e73a275f..b2de423c 100644 --- a/.github/workflows/linux_x64_docker_ci.yml +++ b/.github/workflows/linux_x64_docker_ci.yml @@ -130,9 +130,10 @@ jobs: cd "$CLEAN_WORKSPACE/build" make unittest -j$(nproc) shell: bash - + - name: Make All run: | + source /opt/miniforge3/bin/activate ${{ env.CONDA_ENV_NAME }} cd "$CLEAN_WORKSPACE/build" make all -j$(nproc) shell: bash diff --git a/.github/workflows/mac_arm64_ci.yml b/.github/workflows/mac_arm64_ci.yml index 6864ca49..7a584c9f 100644 --- a/.github/workflows/mac_arm64_ci.yml +++ b/.github/workflows/mac_arm64_ci.yml @@ -100,6 +100,7 @@ jobs: - name: Make All run: | + source /opt/miniforge3/bin/activate ${{ env.CONDA_ENV_NAME }} cd "$CLEAN_WORKSPACE/build" make all -j$(nproc) shell: bash From 2fcd7439a5a2e0c1940477c3378f2c34da24a74d Mon Sep 17 00:00:00 2001 From: Jianning Wang Date: Tue, 27 Jan 2026 12:44:55 +0800 Subject: [PATCH 3/5] mac ci doesn't need activation --- .github/workflows/mac_arm64_ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/mac_arm64_ci.yml b/.github/workflows/mac_arm64_ci.yml index 7a584c9f..6864ca49 100644 --- a/.github/workflows/mac_arm64_ci.yml +++ b/.github/workflows/mac_arm64_ci.yml @@ -100,7 +100,6 @@ jobs: - name: Make All run: | - source /opt/miniforge3/bin/activate ${{ env.CONDA_ENV_NAME }} cd "$CLEAN_WORKSPACE/build" make all -j$(nproc) shell: bash From b36901f3de0560d7218a49b23856492384eb8a53 Mon Sep 17 00:00:00 2001 From: Jianning Wang Date: Tue, 27 Jan 2026 14:24:45 +0800 Subject: [PATCH 4/5] fix linux --- .github/workflows/linux_x64_docker_ci.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/linux_x64_docker_ci.yml b/.github/workflows/linux_x64_docker_ci.yml index b2de423c..984b158d 100644 --- a/.github/workflows/linux_x64_docker_ci.yml +++ b/.github/workflows/linux_x64_docker_ci.yml @@ -115,7 +115,8 @@ jobs: CMAKE_GENERATOR="Unix Makefiles" \ CMAKE_BUILD_PARALLEL_LEVEL="$NPROC" \ - pip install -v . + pip install -v . \ + --config-settings='cmake.define.BUILD_TOOLS="ON"' shell: bash - name: Run Python Tests with Coverage @@ -130,10 +131,3 @@ jobs: cd "$CLEAN_WORKSPACE/build" make unittest -j$(nproc) shell: bash - - - name: Make All - run: | - source /opt/miniforge3/bin/activate ${{ env.CONDA_ENV_NAME }} - cd "$CLEAN_WORKSPACE/build" - make all -j$(nproc) - shell: bash From 914322d90da908b21bc9dfcccd9346dc6243fe10 Mon Sep 17 00:00:00 2001 From: Jianning Wang Date: Tue, 27 Jan 2026 15:18:12 +0800 Subject: [PATCH 5/5] sync mac ci --- .github/workflows/mac_arm64_ci.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/mac_arm64_ci.yml b/.github/workflows/mac_arm64_ci.yml index 6864ca49..8145ca0a 100644 --- a/.github/workflows/mac_arm64_ci.yml +++ b/.github/workflows/mac_arm64_ci.yml @@ -83,7 +83,8 @@ jobs: CMAKE_GENERATOR="Unix Makefiles" \ CMAKE_BUILD_PARALLEL_LEVEL="$NPROC" \ - pip install -v . + pip install -v . \ + --config-settings='cmake.define.BUILD_TOOLS="ON"' shell: bash - name: Run Python Tests with Coverage @@ -97,9 +98,3 @@ jobs: cd "$CLEAN_WORKSPACE/build" make unittest -j 16 shell: bash - - - name: Make All - run: | - cd "$CLEAN_WORKSPACE/build" - make all -j$(nproc) - shell: bash