php7.4 - usort() needs int, not bool

[pauljherring]

https://github.com/andreskrey/readability.php/blob/master/src/Readability.php#L198

                    // No luck after removing flags, just return the longest text we found during the different loops
                    usort($this->attempts, function ($a, $b) {
                        return $a['textLength'] < $b['textLength'];   // L198
                    });

php 7.4 is complaining:

usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero

Suggested fix:

- return $a['textLength'] < $b['textLength'];
+ return $b['textLength'] - $a['textLength'];

(NB: replacing < with -, and swapped operands)

Testing:

<?php

function f1(&$x){ // original
	usort($x, function ($a, $b) {
		return $a['textLength'] < $b['textLength'];
	});
}

function f2(&$x){ // proposed change
	usort($x, function ($a, $b) {
		return $b['textLength'] - $a['textLength'];
	});
}

$a = [
	['textLength'=> 5, 'b'=>'1'],
	['textLength'=> 7, 'b'=>'2'],
	['textLength'=> 3, 'b'=>'3'],
	['textLength'=> 1, 'b'=>'4'],
];

$b = $a;
f1($b);
print_r($b);

$b = $a;
f2($b);
print_r($b);

Output:

$ php -e x.php
Array
(
    [0] => Array
        (
            [textLength] => 7
            [b] => 2
        )

    [1] => Array
        (
            [textLength] => 5
            [b] => 1
        )

    [2] => Array
        (
            [textLength] => 3
            [b] => 3
        )

    [3] => Array
        (
            [textLength] => 1
            [b] => 4
        )

)
Array
(
    [0] => Array
        (
            [textLength] => 7
            [b] => 2
        )

    [1] => Array
        (
            [textLength] => 5
            [b] => 1
        )

    [2] => Array
        (
            [textLength] => 3
            [b] => 3
        )

    [3] => Array
        (
            [textLength] => 1
            [b] => 4
        )

)

[andreskrey]

Looks alright, want to submit a PR to see how the test behave with this change?

[pauljherring]

I can't run the tests:

$ make test-all
docker-compose up -d php-7.3-libxml-2.9.9 php-7.2-libxml-2.9.9 php-7.1-libxml-2.9.9 php-7.0-libxml-2.9.9
Creating network "readabilityphp_default" with the default driver
Building php-7.0-libxml-2.9.9
Step 1/7 : ARG PHP_VERSION
...
Step 6/7 : RUN pecl install xdebug$(if [ ! ${XDEBUG_VERSION} = '' ]; then echo -${XDEBUG_VERSION} ; fi) && docker-php-ext-enable xdebug
 ---> Running in 0b6cc852d4fe
WARNING: channel "pecl.php.net" has updated its protocols, use "pecl channel-update pecl.php.net" to update
pecl/xdebug requires PHP (version >= 7.2.0, version <= 8.0.99), installed version is 7.0.33
No valid packages found
install failed
ERROR: Service 'php-7.0-libxml-2.9.9' failed to build : The command '/bin/sh -c pecl install xdebug$(if [ ! ${XDEBUG_VERSION} = '' ]; then echo -${XDEBUG_VERSION} ; fi) && docker-php-ext-enable xdebug' returned a non-zero code: 1
make: *** [Makefile:18: start] Error 1

and I'm not sure how to go about sorting that bit..

[andreskrey]

Weird, xdebug probably dropped support for 7.0.

Can you just commit your code and submit a PR? Travis will run all the tests.