Skip to content

Duplicate Normalize line in the lightmapper code #20

@noisecrime

Description

@noisecrime

Hi,

Been looking through the code and came across this in lightmapper.h

569: ctx->meshPosition.sample.direction = lm_normalize3(lm_add3(n0, lm_add3(lm_scale3(nv2, uv.x), lm_scale3(nv1, uv.y))));
570: ctx->meshPosition.sample.direction = lm_normalize3(ctx->meshPosition.sample.direction);

Unless I'm reading this wrong it looks to me like a typo as direction is being normalized twice.
So I imagine line 570 can just be removed or commented out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions