Skip to content

Commit 2080abd

Browse files
committed
fixup! refactor: remove tree-kill dependency and refactor killAllProcesses to use native childProc.kill with retries.
1 parent 52b53ad commit 2080abd

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

.github/workflows/pr.yml

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124
- name: Run CLI E2E tests
125125
run: pnpm bazel test --test_env=E2E_SHARD_TOTAL=6 --test_env=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests:e2e.${{ matrix.subset }}_node${{ matrix.node }}
126126

127-
build-e2e-windows-subset:
127+
build-e2e-windows:
128128
runs-on: ubuntu-latest
129129
steps:
130130
- name: Initialize environment
@@ -133,12 +133,15 @@ jobs:
133133
uses: angular/dev-infra/github-actions/bazel/setup@9cc477855b9788df6257301074a1629bc3545722
134134
- name: Setup Bazel RBE
135135
uses: angular/dev-infra/github-actions/bazel/configure-remote@9cc477855b9788df6257301074a1629bc3545722
136+
with:
137+
google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}
136138
- name: Install node modules
137139
run: pnpm install --frozen-lockfile
138140
- name: Build E2E tests for Windows on Linux
139141
run: |
140142
pnpm bazel build \
141143
--config=e2e \
144+
//tests:e2e.webpack_node24 \
142145
//tests:e2e.esbuild_node24 \
143146
--platforms=tools:windows_x64
144147
- name: Store built Windows E2E tests
@@ -151,8 +154,14 @@ jobs:
151154
retention-days: 1
152155
if-no-files-found: 'error'
153156

154-
e2e-windows-subset:
155-
needs: build-e2e-windows-subset
157+
e2e-windows:
158+
needs: build-e2e-windows
159+
strategy:
160+
fail-fast: false
161+
matrix:
162+
node: [24]
163+
subset: [esbuild, webpack]
164+
shard: [0, 1, 2, 3, 4, 5]
156165
runs-on: windows-2025
157166
steps:
158167
- name: Initialize environment
@@ -167,10 +176,10 @@ jobs:
167176
- name: Run CLI E2E tests
168177
uses: ./.github/shared-actions/windows-bazel-test
169178
with:
170-
test_target_name: e2e.esbuild_node24
179+
test_target_name: e2e.${{ matrix.subset }}_node${{ matrix.node }}
171180
env:
172-
E2E_SHARD_TOTAL: 1
173-
TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild,serve}.ts
181+
E2E_SHARD_TOTAL: 6
182+
E2E_SHARD_INDEX: ${{ matrix.shard }}
174183

175184
e2e-package-managers:
176185
needs: build

0 commit comments

Comments
 (0)