refactor: remove tree-kill dependency and refactor killAllProcesses to use native childProc.kill.

Remove last `tree-kill` package usage.

Author: alan-agius4

.github/workflows/pr.yml

@@ -124,7 +124,7 @@ jobs:
       - name: Run CLI E2E tests
         run: pnpm bazel test --test_env=E2E_SHARD_TOTAL=6 --test_env=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
-  build-e2e-windows-subset:
+  build-e2e-windows:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
@@ -133,12 +133,15 @@ jobs:
         uses: angular/dev-infra/github-actions/bazel/setup@9cc477855b9788df6257301074a1629bc3545722
       - name: Setup Bazel RBE
         uses: angular/dev-infra/github-actions/bazel/configure-remote@9cc477855b9788df6257301074a1629bc3545722
+        with:
+          google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}
       - name: Install node modules
         run: pnpm install --frozen-lockfile
       - name: Build E2E tests for Windows on Linux
         run: |
           pnpm bazel build \
             --config=e2e \
+            //tests:e2e.webpack_node24 \
             //tests:e2e.esbuild_node24 \
             --platforms=tools:windows_x64
       - name: Store built Windows E2E tests
@@ -151,8 +154,14 @@ jobs:
           retention-days: 1
           if-no-files-found: 'error'
 
-  e2e-windows-subset:
-    needs: build-e2e-windows-subset
+  e2e-windows:
+    needs: build-e2e-windows
+    strategy:
+      fail-fast: false
+      matrix:
+        node: [24]
+        subset: [esbuild, webpack]
+        shard: [0, 1, 2, 3, 4, 5]
     runs-on: windows-2025
     steps:
       - name: Initialize environment
@@ -167,10 +176,10 @@ jobs:
       - name: Run CLI E2E tests
         uses: ./.github/shared-actions/windows-bazel-test
         with:
-          test_target_name: e2e.esbuild_node24
+          test_target_name: e2e.${{ matrix.subset }}_node${{ matrix.node }}
         env:
-          E2E_SHARD_TOTAL: 1
-          TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild,serve}.ts
+          E2E_SHARD_TOTAL: 6
+          E2E_SHARD_INDEX: ${{ matrix.shard }}
 
   e2e-package-managers:
     needs: build

pnpm-lock.yaml

@@ -20,6 +20,5 @@ ts_project(
         "//:node_modules/verdaccio-auth-memory",
         "//tests:node_modules/@types/tar-stream",
         "//tests:node_modules/tar-stream",
-        "//tests:node_modules/tree-kill",
     ],
 )

tests/e2e/utils/BUILD.bazel

@@ -1,9 +1,9 @@
 import { spawn, SpawnOptions } from 'node:child_process';
 import * as child_process from 'node:child_process';
 import { getGlobalVariable, getGlobalVariablesEnv } from './env';
-import treeKill from 'tree-kill';
 import { delimiter, join, resolve } from 'node:path';
 import { stripVTControlCharacters, styleText } from 'node:util';
+import { assertIsError } from './utils';
 
 interface ExecOptions {
   silent?: boolean;
@@ -255,26 +255,43 @@ export async function waitForAnyProcessOutputToMatch(
   return matchingProcess;
 }
 
-export async function killAllProcesses(signal = 'SIGTERM'): Promise<void> {
+/**
+ * Kills a process by PID
+ * @param pid The PID of the process to kill
+ * @param signal The signal to send to the process
+ */
+async function killProcess(pid: number, signal: NodeJS.Signals): Promise<void> {
+  if (process.platform === 'win32') {
+    // /T kills child processes, /F forces it
+    await new Promise<void>((resolve) => {
+      child_process.exec(`taskkill /pid ${pid} /T /F`, () => resolve());
+    });
+  } else {
+    // Use -pid to signal the entire process group
+    try {
+      process.kill(-pid, signal);
+    } catch (error) {
+      assertIsError(error);
+      if (error.code !== 'ESRCH') {
+        throw error;
+      }
+    }
+  }
+}
+
+/**
+ * Kills all tracked processes
+ */
+export async function killAllProcesses(signal: NodeJS.Signals = 'SIGTERM'): Promise<void> {
   const processesToKill: Promise<void>[] = [];
 
   while (_processes.length) {
     const childProc = _processes.pop();
-    if (!childProc || childProc.pid === undefined) {
+    if (!childProc || childProc.pid === undefined || childProc.killed) {
       continue;
     }
 
-    processesToKill.push(
-      new Promise<void>((resolve) => {
-        treeKill(childProc.pid!, signal, () => {
-          // Ignore all errors.
-          // This is due to a race condition with the `waitForMatch` logic.
-          // where promises are resolved on matches and not when the process terminates.
-          // Also in some cases in windows we get `The operation attempted is not supported`.
-          resolve();
-        });
-      }),
-    );
+    processesToKill.push(killProcess(childProc.pid, signal));
   }
 
   await Promise.all(processesToKill);

tests/e2e/utils/process.ts

@@ -2,7 +2,6 @@
   "devDependencies": {
     "@types/tar-stream": "3.1.4",
     "@angular-devkit/schematics": "workspace:*",
-    "tar-stream": "3.1.7",
-    "tree-kill": "1.2.2"
+    "tar-stream": "3.1.7"
   }
 }