refactor: remove tree-kill dependency and refactor killAllProcesses to use native childProc.kill.

Remove last `tree-kill` package usage.

Author: alan-agius4

pnpm-lock.yaml

@@ -20,6 +20,5 @@ ts_project(
         "//:node_modules/verdaccio-auth-memory",
         "//tests:node_modules/@types/tar-stream",
         "//tests:node_modules/tar-stream",
-        "//tests:node_modules/tree-kill",
     ],
 )

tests/e2e/utils/BUILD.bazel

@@ -1,7 +1,6 @@
 import { spawn, SpawnOptions } from 'node:child_process';
 import * as child_process from 'node:child_process';
 import { getGlobalVariable, getGlobalVariablesEnv } from './env';
-import treeKill from 'tree-kill';
 import { delimiter, join, resolve } from 'node:path';
 import { stripVTControlCharacters, styleText } from 'node:util';
 
@@ -255,26 +254,34 @@ export async function waitForAnyProcessOutputToMatch(
   return matchingProcess;
 }
 
-export async function killAllProcesses(signal = 'SIGTERM'): Promise<void> {
+/**
+ * Kills a process by PID
+ * @param pid The PID of the process to kill
+ * @param signal The signal to send to the process
+ */
+async function killProcess(pid: number, signal: NodeJS.Signals): Promise<void> {
+  if (process.platform === 'win32') {
+    // /T kills child processes, /F forces it
+    await exec(`taskkill /pid ${pid} /T /F`);
+  } else {
+    // Use -pid to signal the entire process group
+    process.kill(-pid, signal);
+  }
+}
+
+/**
+ * Kills all tracked processes
+ */
+export async function killAllProcesses(signal: NodeJS.Signals = 'SIGTERM'): Promise<void> {
   const processesToKill: Promise<void>[] = [];
 
   while (_processes.length) {
     const childProc = _processes.pop();
-    if (!childProc || childProc.pid === undefined) {
+    if (!childProc || childProc.pid === undefined || childProc.killed) {
       continue;
     }
 
-    processesToKill.push(
-      new Promise<void>((resolve) => {
-        treeKill(childProc.pid!, signal, () => {
-          // Ignore all errors.
-          // This is due to a race condition with the `waitForMatch` logic.
-          // where promises are resolved on matches and not when the process terminates.
-          // Also in some cases in windows we get `The operation attempted is not supported`.
-          resolve();
-        });
-      }),
-    );
+    processesToKill.push(killProcess(childProc.pid, signal));
   }
 
   await Promise.all(processesToKill);

tests/e2e/utils/process.ts

@@ -2,7 +2,6 @@
   "devDependencies": {
     "@types/tar-stream": "3.1.4",
     "@angular-devkit/schematics": "workspace:*",
-    "tar-stream": "3.1.7",
-    "tree-kill": "1.2.2"
+    "tar-stream": "3.1.7"
   }
 }