-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: keybind hint overlay #8738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: keybind hint overlay #8738
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
However, this appears to be a different feature (status line hints vs. keybind hint overlay), so it's related but not a duplicate. The current PR (#8738) is specifically about refining the keybind hint overlay with new settings for |
|
Why does |
One is for the home screen, one is for the session. Unfortunately there's no way of knowing if a keybinding is currently being listened for (afaik), so there's no clean way to deduplicate. If there was a variation on |
|
@iamdavidhill looks like you have something related in the works. Might make sense for this to reuse your keybind table component? |
Small test bug looks like I'll send this to David |
|
i think this is really good, here are my thoughts... there are three similar features in flux here: 1. command palette which we have - lets you search and enter on a command i think there's room for all three in the product. i think they should all follow the same design patterns, which they mostly already do but i think if we took a closer look with this in mind we could polish things up. they should all feel super-related because they're all subsets of the same problem space. as useful as it is, i'm not sure if the "whichkey" experience should be on by default. i think this is something you should enable. when we have settings in the tui this will be much more discoverable. |
What does this PR do?
Fixes #8730
Added settings:
keybind_hint.enabled(default true)keybind_hint.delay_msHow did you verify your code works?
Manually tested, both from home screen and from session with different screen sizes.
Screenshots
In-session
Home screen
Tiny screen
Large screen