Skip to content

Conversation

@NathanFlurry
Copy link

What does this PR do?

Fixes #8730

Added settings:

  • keybind_hint.enabled (default true)
  • keybind_hint.delay_ms

How did you verify your code works?

Manually tested, both from home screen and from session with different screen sizes.

Screenshots

In-session CleanShot 2026-01-15 at 12 35 39@2x
Home screen CleanShot 2026-01-15 at 12 35 30@2x
Tiny screen CleanShot 2026-01-15 at 12 50 31@2x
Large screen CleanShot 2026-01-15 at 12 50 36@2x

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

Related PR:

However, this appears to be a different feature (status line hints vs. keybind hint overlay), so it's related but not a duplicate. The current PR (#8738) is specifically about refining the keybind hint overlay with new settings for keybind_hint.enabled and keybind_hint.delay_ms.

@NathanFlurry NathanFlurry changed the title feat: refine keybind hint overlay feat: keybind hint overlay Jan 15, 2026
@heymaaz
Copy link

heymaaz commented Jan 15, 2026

Why does h have 2 options??

@NathanFlurry
Copy link
Author

Why does h have 2 options??

One is for the home screen, one is for the session. Unfortunately there's no way of knowing if a keybinding is currently being listened for (afaik), so there's no clean way to deduplicate.

If there was a variation on useKeybind to pass in the expected keybind, then there's probably a way to check what mounted components are listening for. That would be a massive refactor, though.

@NathanFlurry
Copy link
Author

@iamdavidhill looks like you have something related in the works. Might make sense for this to reuse your keybind table component?

Related thread

@rekram1-node
Copy link
Collaborator

Expected: "shift+return"
Received: "shift+↵"

Small test bug looks like


I'll send this to David

@iamdavidhill
Copy link
Contributor

iamdavidhill commented Jan 16, 2026

i think this is really good, here are my thoughts...

there are three similar features in flux here:

1. command palette which we have - lets you search and enter on a command
2. "whichkey" for leader key experience - very specific to just 'ctrl+x' experience, overlays the content so nothing jumps, i also like the fact that it overlays because it hides the prompt input when in a session which makes it clear the prompt is disabled and the leader key is active
3. "cheatsheet" - all keybinds, not just leader key, pushes the content up so that you can leave it open while you work and learn things, for example you can try out all the prompt input keybinds while the cheatsheet is open

i think there's room for all three in the product. i think they should all follow the same design patterns, which they mostly already do but i think if we took a closer look with this in mind we could polish things up. they should all feel super-related because they're all subsets of the same problem space.

as useful as it is, i'm not sure if the "whichkey" experience should be on by default. i think this is something you should enable. when we have settings in the tui this will be much more discoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Keybind hints

4 participants