From 6658dfac9fd7d8d1ba5cd84432e781a71d8150a0 Mon Sep 17 00:00:00 2001 From: Kent Wu Date: Wed, 11 Mar 2026 12:21:16 -0400 Subject: [PATCH 1/2] ci: bump Node.js from 20 to 24 LTS --- .env | 2 +- .github/workflows/rc.yaml | 4 ++-- .github/workflows/test.yaml | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.env b/.env index b339ad85..2e16546d 100644 --- a/.env +++ b/.env @@ -37,4 +37,4 @@ ARCH=amd64 DEBIAN_CODE_NAME=bookworm # Default versions for various dependencies -NODE=20 +NODE=24 diff --git a/.github/workflows/rc.yaml b/.github/workflows/rc.yaml index c18ed0eb..05fdeba3 100644 --- a/.github/workflows/rc.yaml +++ b/.github/workflows/rc.yaml @@ -103,7 +103,7 @@ jobs: - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: cache: npm - node-version: 20 + node-version: 24 - name: Install dependencies run: | npm ci @@ -166,7 +166,7 @@ jobs: - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: cache: npm - node-version: 20 + node-version: 24 - name: Install dependencies run: | npm ci diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6faaee8e..32948c7c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -46,7 +46,7 @@ jobs: - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: cache: npm - node-version: 20 + node-version: 24 - name: Install ESLint dependencies run: | npm ci @@ -71,7 +71,7 @@ jobs: pre-commit run --show-diff-on-failure --color=always --all-files docker: - name: Debian Node.js 20 + name: Debian Node.js 24 runs-on: ubuntu-latest timeout-minutes: 60 env: @@ -95,7 +95,7 @@ jobs: strategy: fail-fast: false matrix: - node: [20] + node: [24] steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Cache @@ -121,7 +121,7 @@ jobs: strategy: fail-fast: false matrix: - node: [20] + node: [24] steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Cache From 3109664ec236c5f6ebc6422568a2d05f9b78ce81 Mon Sep 17 00:00:00 2001 From: Kent Wu Date: Thu, 12 Mar 2026 11:05:42 -0400 Subject: [PATCH 2/2] matrix 20, 24 --- .github/workflows/test.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 32948c7c..ff97ce1d 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -71,19 +71,24 @@ jobs: pre-commit run --show-diff-on-failure --color=always --all-files docker: - name: Debian Node.js 24 + name: Debian Node.js ${{ matrix.node }} runs-on: ubuntu-latest timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + node: [20, 24] env: DOCKER_VOLUME_PREFIX: .docker/ + NODE: ${{ matrix.node }} steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Cache uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3 with: path: .docker - key: jest-docker-${{ hashFiles('src/**/*.ts', 'test/**/*.ts', 'package-lock.json') }} - restore-keys: jest-docker- + key: jest-docker-${{ matrix.node }}-${{ hashFiles('src/**/*.ts', 'test/**/*.ts', 'package-lock.json') }} + restore-keys: jest-docker-${{ matrix.node }}- - name: Run run: | docker compose run debian @@ -95,7 +100,7 @@ jobs: strategy: fail-fast: false matrix: - node: [24] + node: [20, 24] steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Cache @@ -121,7 +126,7 @@ jobs: strategy: fail-fast: false matrix: - node: [24] + node: [20, 24] steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Cache